refactor: Use async in aws/package/compile/events#8873
Merged
pgrzesik merged 1 commit intoserverless:masterfrom Feb 3, 2021
Merged
Conversation
Covered the following paths: * `lib/plugins/aws/package/compile/events/*.js` * `lib/plugins/aws/package/compile/events/alb` * `lib/plugins/aws/package/compile/events/lib` * `lib/plugins/aws/package/compile/events/s3`
Codecov Report
@@ Coverage Diff @@
## master #8873 +/- ##
=======================================
Coverage 87.74% 87.74%
=======================================
Files 266 266
Lines 9919 9919
=======================================
Hits 8703 8703
Misses 1216 1216
Continue to review full report at Codecov.
|
pgrzesik
approved these changes
Feb 3, 2021
Contributor
pgrzesik
left a comment
pgrzesik
left a comment
There was a problem hiding this comment.
Thank you @ifitzsimmons, it looks great 👍
pgrzesik
changed the title
async in aws/package/compile/events
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covered the following paths:
lib/plugins/aws/package/compile/events/*.jslib/plugins/aws/package/compile/events/alblib/plugins/aws/package/compile/events/liblib/plugins/aws/package/compile/events/s3Addresses: #8368