API: Introduce serviceDir and configurationFilename constructor options
#9307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
changed the title
configurationPath with serviceDir and configurationFilenameserviceDir and configurationFilename constructor options
medikoo
force-pushed
the
0414-introduce-service-dir
branch
3 times, most recently
from
fa626b0 to
0000d8e
Compare
Codecov Report
@@ Coverage Diff @@
## master #9307 +/- ##
==========================================
+ Coverage 86.87% 86.91% +0.04%
==========================================
Files 316 316
Lines 11767 11773 +6
==========================================
+ Hits 10223 10233 +10
+ Misses 1544 1540 -4
Continue to review full report at Codecov.
|
In place of `configurationPath`
`serviceDir` and `configurationFilename` options are favored over of `configurationPath`
Support for `servicePath` is maintained until next major
medikoo
force-pushed
the
0414-introduce-service-dir
branch
from
0000d8e to
0bdb1b8
Compare
pgrzesik
approved these changes
Apr 16, 2021
Contributor
pgrzesik
left a comment
pgrzesik
left a comment
There was a problem hiding this comment.
Looks great, well done 👍
medikoo
added a commit
that referenced
this pull request
Apr 20, 2021
Accidentally removed with #9307
medikoo
added a commit
that referenced
this pull request
Apr 20, 2021
Accidentally removed with #9307
wwwehr
pushed a commit
to wwwehr/serverless
that referenced
this pull request
Apr 27, 2021
Accidentally removed with serverless#9307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configurationPathwas introduced in first refactors as mid step, still more natural in programmatic usage is to refer toserviceDirand eventuallyconfigurationFilename(but not many use cases for that one)In the end eventual service configuration to be passed to
Serverlessconstructor will consist of following options:configuration- Service configuration objectserviceDir- Base path for resolution of any paths that are configured in service configurationconfigurationFilename- Needed just in some cases (1) Error reporting (when we want to mention specifically configuration filename) (2) To update service configuration programmatically (e.g. to add plugin topluginssection withplugin installcommand). (As internals will become more and more modular, this property may appear at some point as optional)(Support for
configurationPathin scope of v2, will be maintained to not break things)Settled on
serviceDir, notservicePath(which was used so far in most places), to indicate that in all cases we deal with directory, also it'll matchbaseDirsetting to be proposed as part of a solution for mulitple service repo handling andsourceDirwhich we plan to introduce with #7920Additionally:
serverless.config.servicePathoccurences withserverless.serviceDir(this attributes to Deprecate "serverless.config" #8836)servicePathvariables toserviceDirin codebase.execSyncto asyncspawnhelped to see internally what's going on)