fix(Templates): Allow usage of google-nodejs-typescript template
#9557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9557 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 322 322
Lines 12109 12109
=======================================
Hits 10483 10483
Misses 1626 1626
Continue to review full report at Codecov.
|
pgrzesik
approved these changes
Jun 7, 2021
Contributor
pgrzesik
left a comment
pgrzesik
left a comment
There was a problem hiding this comment.
Thank you @CorentinDoue, good catch 👍
pgrzesik
changed the title
google-nodejs-typescript template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9445 adds
google-nodejs-typescripttemplate but it can't be used because it is not in therecommended-list.This PR allow the usage of the template by adding its name in the
recommended-list.