Skip to content

fix #19 - Enable GitHub CodeQL scanning#132

Merged
ricardozanini merged 4 commits intoserverlessworkflow:mainfrom
fantonangeli:issue-19-Enable-GitHub-CodeQL-scanning
Apr 30, 2026
Merged

fix #19 - Enable GitHub CodeQL scanning#132
ricardozanini merged 4 commits intoserverlessworkflow:mainfrom
fantonangeli:issue-19-Enable-GitHub-CodeQL-scanning

Conversation

@fantonangeli
Copy link
Copy Markdown
Member

Closes #19

Summary

Configure GitHub’s CodeQL code scanning for this repository to analyze the JavaScript/TypeScript codebase, catch common security issues early, and surface findings in the repo Security → Code scanning alerts.

Goals

  • Enable CodeQL analysis for JS/TS to detect common vulnerabilities and insecure patterns.
  • Run analysis automatically via GitHub Actions and publish results to the Security tab.
  • Keep configuration lightweight and maintainable for an OSS repo.

Non-Goals

  • Custom CodeQL queries on day one.
  • Scanning non-JS/TS languages unless required.
  • Treating CodeQL as a replacement for unit tests/linting.

Notes:

  • I enabled the CodeQL scan for TS/JS files and also for GH Actions.
    The scan found 2 medium issues in 2 CIs and I fixed them in this PR:
    • .github/workflows/ci_check_license_headers.yaml
    • .github/workflows/sync-issues-to-project.yml (CC @dgutierr )

Preview:

I created 2 PRs to test the result on my fork:

Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Copilot AI review requested due to automatic review settings April 30, 2026 09:50
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables GitHub CodeQL code scanning for the repository to analyze the JavaScript/TypeScript codebase (and GitHub Actions workflows), publishing findings to the repo’s Code scanning alerts.

Changes:

  • Add a new GitHub Actions workflow to run CodeQL analysis on push, pull_request, and a weekly schedule.
  • Harden existing workflows by explicitly setting minimal GITHUB_TOKEN permissions (contents: read) to address CodeQL findings.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/sync-issues-to-project.yml Adds explicit minimal workflow permissions (contents: read).
.github/workflows/ci_codeql.yml Introduces CodeQL scanning workflow for JS/TS and GitHub Actions.
.github/workflows/ci_check_license_headers.yaml Adds explicit minimal workflow permissions (contents: read).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@lornakelly lornakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Copy Markdown
Contributor

@kumaradityaraj kumaradityaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardozanini ricardozanini merged commit 50201c7 into serverlessworkflow:main Apr 30, 2026
11 of 12 checks passed
@fantonangeli fantonangeli deleted the issue-19-Enable-GitHub-CodeQL-scanning branch April 30, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable GitHub CodeQL scanning

6 participants