-
Notifications
You must be signed in to change notification settings - Fork 8
fix #126 - feat: Implement release and changelog process #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fantonangeli
wants to merge
12
commits into
serverlessworkflow:main
Choose a base branch
from
fantonangeli:issue-126-feat-Implement-release-and-changelog-process
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bf0b51c
Implemented changeset configuration and CIs
fantonangeli 2daf090
First changeset creation
fantonangeli 2319502
Publish CI refinements
fantonangeli 18fac1e
Merge remote-tracking branch 'upstream/main' into issue-126-feat-Impl…
fantonangeli 02887ae
Removed checkout ref, which can point to a commit newer than the
fantonangeli 3330f24
Last refinements from tests
fantonangeli 2659682
Readd workspace protocol check
fantonangeli 5f39691
Doc update
fantonangeli bc4305b
Fixed copilot's comments
fantonangeli 999dc5f
Merge remote-tracking branch 'upstream/main' into issue-126-feat-Impl…
fantonangeli 18e66b2
Fixes comment: https://github.com/serverlessworkflow/editor/pull/154#…
fantonangeli 5a8de15
Fixes comment: https://github.com/serverlessworkflow/editor/pull/154#…
fantonangeli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "changelog": ["@changesets/changelog-github", { "repo": "serverlessworkflow/editor" }], | ||
| "commit": false, | ||
| "fixed": [["@serverlessworkflow/*"]], | ||
| "access": "public", | ||
| "baseBranch": "main", | ||
| "updateInternalDependencies": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@serverlessworkflow/i18n": minor | ||
| "@serverlessworkflow/diagram-editor": minor | ||
| --- | ||
|
|
||
| Setup changeset for first minor release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # | ||
| # Copyright 2021-Present The Serverless Workflow Specification Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| name: "Setup CI" | ||
| description: "Setup Node.js and pnpm for CI workflows" | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Setup Node | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
|
fantonangeli marked this conversation as resolved.
|
||
| with: | ||
| node-version: 24 | ||
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8 | ||
| with: | ||
| version: 10.31.0 | ||
| cache: true | ||
|
fantonangeli marked this conversation as resolved.
fantonangeli marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # | ||
| # Copyright 2021-Present The Serverless Workflow Specification Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| name: "Release :: Prepare" | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| prepare-release: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| - name: Setup CI | ||
| uses: ./.github/actions/setup-ci | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Create Release Pull Request | ||
| uses: changesets/action@63a615b9cd06ba9a3e6d13796c7fbcb080a60a0b # v1.8.0 | ||
| with: | ||
| version: pnpm changeset version | ||
| title: "chore: version packages" | ||
| commit: | | ||
| chore: version packages | ||
|
|
||
| Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> | ||
| commitMode: github-api | ||
| createGithubReleases: false | ||
|
fantonangeli marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # | ||
| # Copyright 2021-Present The Serverless Workflow Specification Authors | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| name: "Release :: Publish" | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [closed] | ||
| branches: | ||
| - main | ||
| - "*.x" | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: read | ||
| id-token: write | ||
|
|
||
| jobs: | ||
| publish: | ||
| if: | | ||
| github.repository == 'serverlessworkflow/editor' && | ||
| github.event.pull_request.merged == true && | ||
| github.event.pull_request.user.login == 'github-actions[bot]' && | ||
| github.event.pull_request.title == 'chore: version packages' && | ||
| startsWith(github.event.pull_request.head.ref, 'changeset-release/') | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout release branch | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
fantonangeli marked this conversation as resolved.
|
||
| with: | ||
|
fantonangeli marked this conversation as resolved.
|
||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup CI | ||
| uses: ./.github/actions/setup-ci | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Install Playwright browsers | ||
| run: pnpm playwright:install:ci | ||
|
|
||
| - name: Build packages | ||
| run: pnpm build:prod | ||
|
|
||
| - name: Publish to npm | ||
| uses: changesets/action@63a615b9cd06ba9a3e6d13796c7fbcb080a60a0b # v1.8.0 | ||
| with: | ||
| publish: pnpm changeset publish | ||
|
fantonangeli marked this conversation as resolved.
|
||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed the rules to verify all the packages are with the same version and not just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <!-- | ||
| Copyright 2021-Present The Serverless Workflow Specification Authors | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
|
|
||
| # Release Process | ||
|
|
||
| ## 1. Prepare Release | ||
|
|
||
| 1. Go to: https://github.com/serverlessworkflow/editor/actions/workflows/prepare-release.yaml | ||
| 2. Click **"Run workflow"** | ||
| 3. Select the branch to release from: | ||
| - **`main`** - for normal releases (1.0.0, 1.1.0, 2.0.0) | ||
| - **`1.0.x`** - for patch releases on a previous release 1.x | ||
| 4. Click **"Run workflow"** | ||
| 5. A release PR with title "chore: version packages" with a version bump will be created by the CI | ||
|
|
||
| ## 2. Review and Merge | ||
|
|
||
| 1. Review the "chore: version packages" PR | ||
| 2. Check version bumps and CHANGELOGs are correct | ||
| 3. Merge the PR to start publishing the new release | ||
|
|
||
| ## 3. Publish (no action needed) | ||
|
|
||
| On merge, the publish workflow automatically (no manual action needed): | ||
|
fantonangeli marked this conversation as resolved.
|
||
|
|
||
| - Builds and tests packages | ||
| - Publishes to npm | ||
| - Creates git tags and GitHub releases | ||
|
|
||
| Check CI run at: [https://github.com/serverlessworkflow/editor/actions/workflows/publish-release.yaml](https://github.com/serverlessworkflow/editor/actions/workflows/publish-release.yaml) | ||
| GH Releases: [https://github.com/serverlessworkflow/editor/releases](https://github.com/serverlessworkflow/editor/releases) | ||
| NPM publishing at: [https://www.npmjs.com/package/@serverlessworkflow/diagram-editor?activeTab=versions](https://www.npmjs.com/package/@serverlessworkflow/diagram-editor?activeTab=versions) | ||
|
|
||
| --- | ||
|
|
||
| # Branching Model | ||
|
|
||
| ## Normal Development (main branch): | ||
|
|
||
| - Development happens on `main` | ||
| - Run "Prepare Release" workflow from main branch | ||
|
|
||
| ## Maintenance Releases (X.Y.x branches): | ||
|
|
||
| Created only when you need to patch an old version while `main` has moved forward. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created this composite action to avoid repetition between actions and make it easier to maintain