fix #65 - feat: create a package.json validation CI#99
Merged
ricardozanini merged 3 commits intoserverlessworkflow:mainfrom Apr 17, 2026
Conversation
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI validation to enforce consistent package.json metadata (versions/licenses) across the monorepo’s workspace packages.
Changes:
- Adds Node + pnpm setup and a license-field check to the license headers workflow.
- Adds a version-field check to the build workflow before install/build steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/ci_check_license_headers.yaml | Adds Node/pnpm setup and validates package.json license values across workspaces. |
| .github/workflows/ci_build.yaml | Adds a recursive check intended to validate workspace package versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI validation to enforce consistent package.json metadata across workspace packages (version and license), aligning with the repo’s standard for monorepo package manifests.
Changes:
- Enforce all workspace package versions are
0.0.0during the build workflow. - Enforce all workspace package licenses are
Apache-2.0during the license-headers workflow. - Align
@serverlessworkflow/i18n’spackage.jsonmetadata (version/license/repository/etc.) with the standard.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/i18n/package.json |
Standardizes package metadata (version/license/repo fields) to match monorepo expectations. |
.github/workflows/ci_build.yaml |
Adds a CI step to validate workspace package versions. |
.github/workflows/ci_check_license_headers.yaml |
Adds a CI step to validate workspace package licenses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fantonangeli
requested review from
handreyrc,
kumaradityaraj,
lornakelly and
ricardozanini
ricardozanini
approved these changes
Apr 16, 2026
fantonangeli
deleted the
issue-65-feat-create-a-package.json-validation-CI
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65
Description
Add a package.json validation CI to enforce that versions and license fields are the same across packages.
Motivation
Check that our package.json files have the right values, following our standard.
Proposed Implementation
Using
pnpm exec+node.syncpackhas an issue checking local versions.jqworks well but can be missed in WinPreview:
Expected CI failures:
Green CI, after package.json fix: