Introduce taskInput, taskOutput and workflowInput methods by mcruzdev · Pull Request #1197 · serverlessworkflow/sdk-java

mcruzdev · 2026-03-03T03:17:55Z

This pull request add input and output methods to DSL.

Copilot

Pull request overview

Adds DSL helpers to simplify enriching inputFrom(...) and outputAs(...) transformations with access to the root workflow input (WorkflowModel), addressing #1196 by reducing boilerplate when reading workflowContext.instanceData().input().

Changes:

Added FuncDSL.enriched(...) and FuncDSL.enrichedOutput(...) helper functions (including root-input-only variants).
Introduced EnrichWithModelBiFunction functional interface to support (typedValue, WorkflowModel) enrichment lambdas.
Added new integration-style tests and updated impl/test Maven dependencies to compile/run them.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java`	Adds new enrichment helpers and their Javadocs.
`experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/EnrichWithModelBiFunction.java`	New functional interface for enrichment with `WorkflowModel`.
`impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java`	New tests covering enriched input/output scenarios.
`impl/test/pom.xml`	Adds test-scope dependencies required by the new tests.
`experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/Step.java`	Minor formatting-only changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

ricardozanini

Looks good, but please consider renaming to enrich instead and fwiw: https://www.enterpriseintegrationpatterns.com/patterns/messaging/DataEnricher.html

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

...uent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/EnrichWithModelBiFunction.java

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

impl/test/pom.xml

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java

fjtirado · 2026-03-04T12:59:41Z

See my comment on the issue, I think the PR needs to be refactor accordingly

fjtirado · 2026-03-04T16:30:30Z

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

+   * @return the deserialized workflow input object of type T
+   */
+  public static <T> T taskInput(WorkflowContextData context, Class<T> inputClass) {
+    return context.instanceData().input().as(inputClass).orElseThrow();


This is not the task input, but overall workflow input.
I will rename all xxxInput as just input, for the sake of brevity

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

Copilot · 2026-03-04T17:03:09Z

impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java

+  @Test
+  void test_export_as_with_input_utility() {
+
+    SoftAssertions softly = new SoftAssertions();
+
+    Workflow workflow =
+        FuncWorkflowBuilder.workflow("enrichOutputWithInputTest")
+            .tasks(
+                function(
+                        "add5",
+                        (Long input) -> {
+                          softly.assertThat(input).isEqualTo(10L);
+                          return input + 5;
+                        },
+                        Long.class)
+                    .exportAs(
+                        (object, workflowContext, taskContextData) -> {
+                          Long input = output(taskContextData, Long.class);
+                          softly.assertThat(input).isEqualTo(15L);


Test name says "input utility", but the body is validating the new output(taskContextData, ...) helper. Renaming the test to match what it covers will make the intent clearer when scanning failures.

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

Copilot · 2026-03-04T17:19:57Z

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

+   * @return the deserialized task output object of type T
+   */
+  public static <T> T output(TaskContextData taskContextData, Class<T> outputClass) {
+    return taskContextData.output().as(outputClass).orElseThrow();
+  }


In output(TaskContextData, Class ...) the parameter is named inputClass, but it represents the output type. Renaming it to outputClass would improve clarity and align with the Javadoc.

Copilot · 2026-03-04T17:19:57Z

impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java

+class FuncDSLEnrichWithTest {
+
+  @Test
+  void test_input_with_input_from() {


Test method names in this module consistently use lower camelCase (e.g., testBasic, testConsoleLogWithArgs). These new tests use underscores (test_input_with_input_from, etc.) and one has inconsistent capitalization (test_enrich_Input...). Please rename them to match the existing convention for readability and consistency.

Suggested change

void test_input_with_input_from() {

void testInputWithInputFrom() {

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

Copilot · 2026-03-04T17:28:52Z

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

+   * @return the deserialized workflow input object of type T
+   */
+  public static <T> T input(WorkflowContextData context, Class<T> inputClass) {
+    return context.instanceData().input().as(inputClass).orElseThrow();


orElseThrow() here will throw a NoSuchElementException with no message, which is hard to debug from DSL usage. Consider throwing an IllegalStateException/IllegalArgumentException with a descriptive message that explains the workflow input is missing or cannot be deserialized into the requested type.

Suggested change

return context.instanceData().input().as(inputClass).orElseThrow();

return context

.instanceData()

.input()

.as(inputClass)

.orElseThrow(

() ->

new IllegalStateException(

"Workflow input is missing or cannot be deserialized into type "

+ inputClass.getName()

+ " when calling FuncDSL.input(WorkflowContextData, Class)."));

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java

Copilot · 2026-03-04T17:28:53Z

impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java

+  }
+
+  @Test
+  void test_enrich_Input_with_workflowInput_task() {


Test method name has inconsistent capitalization (test_enrich_Input...) compared to the other test methods in this class. Renaming it to use consistent lower_snake_case (or whatever naming pattern the file is following) will make the suite easier to scan and grep.

Suggested change

void test_enrich_Input_with_workflowInput_task() {

void test_enrich_input_with_workflow_input_task() {

impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>

Copilot AI review requested due to automatic review settings March 3, 2026 03:17

mcruzdev requested a review from fjtirado as a code owner March 3, 2026 03:17

Copilot started reviewing on behalf of mcruzdev March 3, 2026 03:18 View session

mcruzdev requested a review from ricardozanini March 3, 2026 03:18

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 3, 2026 12:40

Copilot AI reviewed Mar 3, 2026

View reviewed changes

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java Outdated Show resolved Hide resolved

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java Outdated Show resolved Hide resolved

Copilot started reviewing on behalf of mcruzdev March 3, 2026 12:52 View session

ricardozanini reviewed Mar 3, 2026

View reviewed changes

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 3, 2026 18:30

Copilot started reviewing on behalf of mcruzdev March 3, 2026 18:31 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 3, 2026 20:26

Copilot started reviewing on behalf of mcruzdev March 3, 2026 20:27 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

mcruzdev force-pushed the issue-1196 branch from 56f4099 to da2d5a5 Compare March 3, 2026 20:39

Copilot AI review requested due to automatic review settings March 3, 2026 21:06

Copilot started reviewing on behalf of mcruzdev March 3, 2026 21:07 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 3, 2026 21:51

mcruzdev force-pushed the issue-1196 branch from 0f9f581 to 4b9a780 Compare March 3, 2026 21:51

Copilot started reviewing on behalf of mcruzdev March 3, 2026 21:51 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java Outdated Show resolved Hide resolved

impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java Outdated Show resolved Hide resolved

mcruzdev changed the title ~~Add enriched and enrichedOutput DSL functions~~ Add enrichInput and enrichOutput DSL functions Mar 4, 2026

fjtirado marked this pull request as draft March 4, 2026 12:59

fjtirado reviewed Mar 4, 2026

View reviewed changes

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java Outdated Show resolved Hide resolved

fjtirado reviewed Mar 4, 2026

View reviewed changes

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java Outdated Show resolved Hide resolved

fjtirado reviewed Mar 4, 2026

View reviewed changes

experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java Outdated Show resolved Hide resolved

fjtirado reviewed Mar 4, 2026

View reviewed changes

impl/test/src/test/java/io/serverlessworkflow/impl/test/FuncDSLEnrichWithTest.java Show resolved Hide resolved

mcruzdev changed the title ~~Add enrichInput and enrichOutput DSL functions~~ Introduce taskInput, taskOutput and workflowInput methods Mar 4, 2026

mcruzdev force-pushed the issue-1196 branch from 74e2680 to 0dacd52 Compare March 4, 2026 16:56

mcruzdev marked this pull request as ready for review March 4, 2026 16:56

Copilot AI review requested due to automatic review settings March 4, 2026 16:56

Copilot started reviewing on behalf of mcruzdev March 4, 2026 16:57 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 4, 2026 17:14

Copilot started reviewing on behalf of mcruzdev March 4, 2026 17:15 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 4, 2026 17:23

Copilot started reviewing on behalf of mcruzdev March 4, 2026 17:23 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Introduce input and output DSL methods

ea3f6ba

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>

mcruzdev force-pushed the issue-1196 branch from c2f36ef to ea3f6ba Compare March 4, 2026 17:38

	void test_input_with_input_from() {
	void testInputWithInputFrom() {

	void test_enrich_Input_with_workflowInput_task() {
	void test_enrich_input_with_workflow_input_task() {

Conversation

mcruzdev commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

ricardozanini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

fjtirado commented Mar 4, 2026

Uh oh!

fjtirado Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

mcruzdev commented Mar 3, 2026 •

edited

Loading

fjtirado Mar 4, 2026 •

edited

Loading