Skip to content

[Fix #1242] Raising workflow error in case there is a conversion issue#1243

Merged
fjtirado merged 1 commit intoserverlessworkflow:mainfrom
fjtirado:Fix_#1242
Mar 18, 2026
Merged

[Fix #1242] Raising workflow error in case there is a conversion issue#1243
fjtirado merged 1 commit intoserverlessworkflow:mainfrom
fjtirado:Fix_#1242

Conversation

@fjtirado
Copy link
Collaborator

Fix #1242

Copilot AI review requested due to automatic review settings March 18, 2026 11:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #1242 by translating HTTP response conversion failures into a workflow-level DATA error, allowing workflows to catch/ignore conversion problems instead of crashing on runtime exceptions.

Changes:

  • Wraps HTTP response entity deserialization in a try/catch to intercept conversion failures.
  • Converts jakarta.ws.rs.ProcessingException into a WorkflowException with Errors.DATA metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot AI review requested due to automatic review settings March 18, 2026 12:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #1242 by converting HTTP response-to-workflow-model conversion failures from uncaught runtime exceptions into a workflow-level DATA error (WorkflowException), allowing workflows to catch/ignore these failures.

Changes:

  • Wrap HTTP invocation Response in a try-with-resources block to ensure it is closed.
  • Catch JAX-RS entity conversion failures during readEntity(...) / response handling and rethrow as WorkflowException with Errors.DATA.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

… a conversion issue

Signed-off-by: fjtirado <ftirados@redhat.com>
@fjtirado fjtirado requested a review from mcruzdev March 18, 2026 12:13
@fjtirado fjtirado merged commit 2124d00 into serverlessworkflow:main Mar 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling http response not convertible to workflow model

2 participants