[Fix #1261] Add scanAll test#1262
Merged
fjtirado merged 1 commit intoserverlessworkflow:mainfrom Mar 23, 2026
Merged
Conversation
mcruzdev
approved these changes
Mar 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for the scanAll method in the persistence test utilities, which was previously untested. The issue was discovered while implementing related functionality in another project.
Changes:
- Added assertion to verify that
scanAllreturns 1 instance when a workflow is active after task completion - Added assertion to verify that
scanAllreturns 0 instances after workflow completion (when the instance is removed from persistence)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: fjtirado <ftirados@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1261