Potential null pointer exception when reading primitive values#1352
Merged
fjtirado merged 1 commit intoserverlessworkflow:mainfrom Apr 29, 2026
Merged
Potential null pointer exception when reading primitive values#1352fjtirado merged 1 commit intoserverlessworkflow:mainfrom
fjtirado merged 1 commit intoserverlessworkflow:mainfrom
Conversation
fjtirado
force-pushed
the
marshalling_utils_fix
branch
from
2b26972 to
c6194ba
Compare
Signed-off-by: fjtirado <ftirados@redhat.com>
fjtirado
force-pushed
the
marshalling_utils_fix
branch
from
c6194ba to
fcd588a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a null-pointer exception risk when unmarshalling primitive values from a byte[] by introducing explicit default handling when the input byte array is null.
Changes:
- Added
writeInt/readInthelpers toMarshallingUtils. - Updated primitive readers (
readBoolean,readShort,readInt) to return default primitive values whenvalue == null. - Refactored
readValueto support an optionaldefaultValuefornullinputs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing null pointer exception when reading primitive if bytes is null