Move output from WorkflowInstanceData to WorkflowInstance#1358
Merged
fjtirado merged 1 commit intoserverlessworkflow:mainfrom Apr 30, 2026
Merged
Move output from WorkflowInstanceData to WorkflowInstance#1358fjtirado merged 1 commit intoserverlessworkflow:mainfrom
fjtirado merged 1 commit intoserverlessworkflow:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #1357 by moving the blocking output() accessor off of WorkflowInstanceData (which is exposed to event listeners via WorkflowContextData) and onto WorkflowInstance.
Changes:
- Remove
WorkflowModel output()fromWorkflowInstanceData. - Add
WorkflowModel output()toWorkflowInstance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowInstanceData.java | Removes output() from the “instance metadata” interface intended for listeners/snapshots. |
| impl/core/src/main/java/io/serverlessworkflow/impl/WorkflowInstance.java | Reintroduces output() on the full WorkflowInstance API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: fjtirado <ftirados@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1357