-
Notifications
You must be signed in to change notification settings - Fork 55
Add Test and Java doc for WorkflowInstance.output #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdproctor
wants to merge
2
commits into
serverlessworkflow:main
Choose a base branch
from
mdproctor:fix/move-output-from-instance-data-1357
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93
−4
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
...st/src/test/java/io/serverlessworkflow/impl/test/WorkflowExecutionListenerOutputTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * Copyright 2020-Present The Serverless Workflow Specification Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.serverlessworkflow.impl.test; | ||
|
|
||
| import static io.serverlessworkflow.api.WorkflowReader.readWorkflowFromClasspath; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import io.serverlessworkflow.impl.WorkflowApplication; | ||
| import io.serverlessworkflow.impl.WorkflowModel; | ||
| import io.serverlessworkflow.impl.lifecycle.WorkflowCompletedEvent; | ||
| import io.serverlessworkflow.impl.lifecycle.WorkflowExecutionListener; | ||
| import java.io.IOException; | ||
| import java.util.Map; | ||
| import java.util.concurrent.atomic.AtomicReference; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| /** | ||
| * Verifies that {@code event.output()} in {@code onWorkflowCompleted} carries the workflow's final | ||
| * output. {@code WorkflowCompletedEvent.output()} is the correct API for accessing output inside | ||
| * the hook — it is populated directly from the task result before the event is published. | ||
| * | ||
| * <p>{@code instanceData().output()} is intentionally absent from {@link | ||
| * io.serverlessworkflow.impl.WorkflowInstanceData}: it is a blocking join on the workflow future | ||
| * intended for callers outside the event chain (e.g. after {@code instance.start().join()}). | ||
| */ | ||
| class WorkflowExecutionListenerOutputTest { | ||
|
|
||
| @Test | ||
| void eventOutputIsPopulatedInOnWorkflowCompleted() throws IOException { | ||
| AtomicReference<WorkflowModel> capturedOutput = new AtomicReference<>(); | ||
|
|
||
| WorkflowExecutionListener listener = | ||
| new WorkflowExecutionListener() { | ||
| @Override | ||
| public void onWorkflowCompleted(WorkflowCompletedEvent event) { | ||
| capturedOutput.set(event.output()); | ||
| } | ||
| }; | ||
|
|
||
| try (WorkflowApplication app = WorkflowApplication.builder().withListener(listener).build()) { | ||
| WorkflowModel result = | ||
| app.workflowDefinition( | ||
| readWorkflowFromClasspath("workflows-samples/simple-expression.yaml")) | ||
| .instance(Map.of()) | ||
| .start() | ||
| .join(); | ||
|
|
||
| assertThat(capturedOutput.get()) | ||
| .as("event.output() must be non-null in onWorkflowCompleted") | ||
| .isNotNull(); | ||
| assertThat(capturedOutput.get().asMap()) | ||
| .as("event.output() must equal the workflow's final output") | ||
| .isEqualTo(result.asMap()); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.