feat: Implement correlation on event filter#1386
Open
matheusandre1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matheus André <matheusandr2@gmail.com>
matheusandre1
force-pushed
the
feature/issue1206
branch
from
a138648 to
ba7cffc
Compare
fjtirado
reviewed
May 19, 2026
Collaborator
There was a problem hiding this comment.
This one belongs to a different PR, isnt it
fjtirado
reviewed
May 19, 2026
Comment on lines
+67
to
+70
| if (additionalProperties != null && !additionalProperties.isEmpty()) { | ||
| // Additional event properties are currently treated as passive metadata for event filters. | ||
| // We keep them from interfering with the core CloudEvent matching and correlation path. | ||
| } |
Collaborator
There was a problem hiding this comment.
I do not get this change, additionalProperties filter is for testing CloudEvent headers, it should not be related with Correlation
fjtirado
reviewed
May 19, 2026
Collaborator
There was a problem hiding this comment.
The UseError builder also belongs to a different Pr, why wont you file first the PR with the DSL changes (exception correlation) and then, once it is merge, you file the correlation, which deserve separate discussion?
fjtirado
reviewed
May 19, 2026
Comment on lines
+108
to
+110
| } catch (Exception e) { | ||
| logger.error("Error processing event for registration type='{}'", registration.type(), e); | ||
| } |
Collaborator
There was a problem hiding this comment.
This is pretty suspicious pece of code, why did you add it?
fjtirado
requested changes
May 19, 2026
Collaborator
fjtirado
left a comment
fjtirado
left a comment
There was a problem hiding this comment.
You need to separate the DSL gap PR you were working on from the Correlation one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it: Closes: #1206
Special notes for reviewers:
Additional information (if needed):