Skip to content

Conversation

@fjtirado
Copy link
Collaborator

@fjtirado fjtirado commented Oct 10, 2025

This is a follow up of #869 to fix the examples (that broke after the introduction of the fix)

JQ expression should not explictly depend on Jackson model. In theory, jq expressions can be used with any model which support JsonNode (WorkflowModel implementation contains an as method that support as parameter JsonNode.class), therefore inclusion of JQ in the dependency set should not impose the usage of Jackson model (not include it in the classpath automatically)

Jackson model module should contain the model itself, but nothing else.

Therefore, Lyfecycle cloud events and schema validation should be different dependencies than the model one

These four modules all shared a dependency with json-utils, which become a separate dependency (which in turn depends on jackson and jackson-cloud events)

To keep dependencies handling as simple as possible from user point of view (and to keep example backward compatiblity), impl-jackson has become a pom packaging (not containing any source file) module, which depends on jackson model, jq expression, schema validation and the lifecycle events.

@fjtirado fjtirado force-pushed the Improving_modularization branch 3 times, most recently from 999056b to fbd2e50 Compare October 10, 2025 10:54
Signed-off-by: fjtirado <ftirados@redhat.com>
@fjtirado fjtirado force-pushed the Improving_modularization branch from fbd2e50 to 07a9b02 Compare October 10, 2025 11:04
@fjtirado fjtirado merged commit eb92e70 into serverlessworkflow:main Oct 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant