Improving modularization/Fixing broken example #872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #869 to fix the examples (that broke after the introduction of the fix)
JQ expression should not explictly depend on Jackson model. In theory, jq expressions can be used with any model which support JsonNode (WorkflowModel implementation contains an
asmethod that support as parameterJsonNode.class), therefore inclusion of JQ in the dependency set should not impose the usage of Jackson model (not include it in the classpath automatically)Jackson model module should contain the model itself, but nothing else.
Therefore, Lyfecycle cloud events and schema validation should be different dependencies than the model one
These four modules all shared a dependency with json-utils, which become a separate dependency (which in turn depends on jackson and jackson-cloud events)
To keep dependencies handling as simple as possible from user point of view (and to keep example backward compatiblity), impl-jackson has become a pom packaging (not containing any source file) module, which depends on jackson model, jq expression, schema validation and the lifecycle events.