Skip to content

[Fix #930] Adding authorization runtime expression #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2025
Merged

[Fix #930] Adding authorization runtime expression #940

merged 1 commit into from
Nov 3, 2025

Conversation

@fjtirado
Copy link
Collaborator

@fjtirado fjtirado commented Oct 31, 2025 •
edited
Loading

Fix #930

This also fixed following things:

  • Secret should be a map, not a string
  • Expression exception should be a workflow exception of the proper type as per spec, not an IllegalArgument one
  • The AdditionaObject factory should accept WorkflowContextData and TaskContextData, so it has not access to internals exposed by their parent interfaces.

@fjtirado fjtirado force-pushed the Fix_#930 branch 6 times, most recently from 42ad553 to d37cef9 Compare November 3, 2025 13:36
@fjtirado fjtirado marked this pull request as ready for review November 3, 2025 13:36
@fjtirado fjtirado marked this pull request as draft November 3, 2025 14:24
@fjtirado fjtirado force-pushed the Fix_#930 branch 2 times, most recently from 5d12db0 to 1304a3a Compare November 3, 2025 15:58
@fjtirado fjtirado marked this pull request as ready for review November 3, 2025 15:59
@fjtirado
[Fix serverlessworkflow#930] Adding authorization runtime expression
4928774 
Signed-off-by: fjtirado <ftirados@redhat.com>
ricardozanini
ricardozanini reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do we already have tests for OAuth2? I see you added for Basic only.

@fjtirado
Copy link
Collaborator Author

fjtirado commented Nov 3, 2025

Also, do we already have tests for OAuth2? I see you added for Basic only.

There are test for Oauth and OpenId already
Secret for Oauth and OpenId will be added with #952

@ricardozanini ricardozanini merged commit c9c41eb into serverlessworkflow:main Nov 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@treblereel treblereel Awaiting requested review from treblereel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement authorization runtime expression

2 participants

@fjtirado @ricardozanini