Skip to content

Conversation

@antmendoza
Copy link
Contributor

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

Add validation to workflowbuilder class, in order to ensure that mandatory fields are set

Special notes for reviewers:

Additional information (if needed):

@antmendoza antmendoza requested a review from tsurdilo as a code owner April 11, 2021 16:38
Signed-off-by: Antonio Mendoza Pérez <antmendoza@gmail.com>
@antmendoza antmendoza force-pushed the add_validation_workflowbuilder branch from 7169cdb to 3bc27e9 Compare April 11, 2021 16:39
@tsurdilo tsurdilo merged commit 400debd into serverlessworkflow:main Apr 11, 2021
antmendoza added a commit to antmendoza/serverlessworkflow_sdk-typescript that referenced this pull request Apr 12, 2021
commit 8177a7b
Author: Antonio Mendoza Pérez <antmendoza@gmail.com>
Date:   Mon Apr 12 08:58:00 2021 +0200

    added methods to workflowbuilder

    Signed-off-by: Antonio Mendoza Pérez <antmendoza@gmail.com>

commit 400debd
Merge: 769dc0e 3bc27e9
Author: Tihomir Surdilovic <tihomir@temporal.io>
Date:   Sun Apr 11 19:02:22 2021 -0400

    Merge pull request serverlessworkflow#2 from antmendoza/add_validation_workflowbuilder

    added validation to workflowBuilder class
@antmendoza antmendoza deleted the add_validation_workflowbuilder branch April 17, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants