-
Notifications
You must be signed in to change notification settings - Fork 170
Add pull policy to run container task #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Simon Emms <simon@simonemms.com>
|
I've not updated the versions from |
|
@mrsimonemms It should be |
cdavernas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Cheers ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for configuring container image pull policies in the run.container task, aligning with Kubernetes conventions. The pull policy controls when container images should be fetched from the registry.
- Adds a
pullPolicyfield to the container task schema with three possible values:ifNotPresent(default),always, andnever - Updates documentation to describe the new field
- Provides an example workflow demonstrating the pull policy usage
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| schema/workflow.yaml | Adds the pullPolicy field definition with enum values to the container task schema |
| examples/run-container-with-pull-policy.yaml | Provides a new example workflow demonstrating the pullPolicy: always configuration |
| dsl-reference.md | Documents the new pullPolicy field in the container task reference section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@cdavernas would you like me to update every 1.0.2 to 1.0.3, or is there an automation that does that? |
No automation as of now, it's a replace all kind of fix. |
|
@cdavernas ok, I'll do as an extra commit tomorrow |
Please specify parts of this PR update:
Discussion or Issue link:
Discussion
Fixes #1138
What this PR does:
Adds a pull policy to the
run.containertask. This has the valuesifNotPresent(default),alwaysandnever, with the same functionality as in Kubernetes.Additional information: