Skip to content

Conversation

@mrsimonemms
Copy link

@mrsimonemms mrsimonemms commented Dec 15, 2025

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

Discussion
Fixes #1138

What this PR does:

Adds a pull policy to the run.container task. This has the values ifNotPresent (default), always and never, with the same functionality as in Kubernetes.

Additional information:

Signed-off-by: Simon Emms <simon@simonemms.com>
@mrsimonemms
Copy link
Author

I've not updated the versions from 1.0.2, but I'm happy to do so - should this be to 1.0.3 or 1.1.0?

@cdavernas
Copy link
Member

@mrsimonemms It should be 1.0.3

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

@cdavernas cdavernas requested a review from Copilot December 17, 2025 08:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for configuring container image pull policies in the run.container task, aligning with Kubernetes conventions. The pull policy controls when container images should be fetched from the registry.

  • Adds a pullPolicy field to the container task schema with three possible values: ifNotPresent (default), always, and never
  • Updates documentation to describe the new field
  • Provides an example workflow demonstrating the pull policy usage

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
schema/workflow.yaml Adds the pullPolicy field definition with enum values to the container task schema
examples/run-container-with-pull-policy.yaml Provides a new example workflow demonstrating the pullPolicy: always configuration
dsl-reference.md Documents the new pullPolicy field in the container task reference section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrsimonemms
Copy link
Author

@cdavernas would you like me to update every 1.0.2 to 1.0.3, or is there an automation that does that?

@cdavernas
Copy link
Member

@cdavernas would you like me to update every 1.0.2 to 1.0.3, or is there an automation that does that?

No automation as of now, it's a replace all kind of fix.

@mrsimonemms
Copy link
Author

@cdavernas ok, I'll do as an extra commit tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pullPolicy to the run.container task definition

2 participants