Skip to content

chore: Bump min Dart to 3.6; introduced Dart workspace#109

Merged
christerswahn merged 6 commits into
mainfrom
fix-progress
May 29, 2026
Merged

chore: Bump min Dart to 3.6; introduced Dart workspace#109
christerswahn merged 6 commits into
mainfrom
fix-progress

Conversation

@christerswahn
Copy link
Copy Markdown
Collaborator

@christerswahn christerswahn commented May 29, 2026

  • Minimum Dart SDK version bumped from 3.3 to 3.6
  • Made repository a Dart workspace
  • Support Melos versions 7.x

Summary by CodeRabbit

  • Chores
    • Increased minimum Dart SDK requirement to 3.6 and broadened CI test range.
    • Added workspace configuration and updated package manager tooling and scripts.
    • Removed obsolete test-file ignore directives.
    • Stopped ignoring pubspec.lock in version control.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19c33835-d2c5-41ba-b131-c6c8c041c47a

📥 Commits

Reviewing files that changed from the base of the PR and between 34788a0 and 7abcb48.

⛔ Files ignored due to path filters (1)
  • pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (14)
  • .github/workflows/ci.yml
  • .gitignore
  • melos.yaml
  • packages/cli_tools/pubspec.yaml
  • packages/cli_tools/pubspec_overrides.yaml
  • packages/cli_tools/test/logger/progress_test.dart
  • packages/cli_tools/test/prompts/confirm_test.dart
  • packages/cli_tools/test/prompts/input_test.dart
  • packages/cli_tools/test/prompts/multiple_select_test.dart
  • packages/cli_tools/test/prompts/select_test.dart
  • packages/cli_tools/test/std_out_logger_test.dart
  • packages/cli_tools/test/test_utils/mock_stdout.dart
  • packages/config/pubspec.yaml
  • pubspec.yaml

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Walkthrough

Upgrade minimum Dart SDK to 3.6 across CI and package manifests, adjust CI matrices to test newer Dart versions, remove Dart 3.3-specific analyzer ignores from tests, add a root workspace and melos configuration/scripts, and stop ignoring pubspec.lock.

Changes

Dart SDK Upgrade and Workspace Migration

Layer / File(s) Summary
Dart SDK version constraints (3.3 → 3.6)
.github/workflows/ci.yml, pubspec.yaml, packages/cli_tools/pubspec.yaml, packages/config/pubspec.yaml
CI matrices for dart_format and dart_analyze_test now start at Dart 3.6; root and package environment.sdk constraints raised to ^3.6.0; dev dependency ranges adjusted.
Remove Dart 3.3 analyzer workarounds
packages/cli_tools/test/prompts/multiple_select_test.dart, packages/cli_tools/test/std_out_logger_test.dart, packages/cli_tools/test/test_utils/mock_stdout.dart
File-level and inline analyzer ignore directives targeting Dart 3.3 (e.g., ignore required for Dart 3.3, unused_local_variable) were removed; test logic unchanged.
Workspace configuration and melos setup
pubspec.yaml, melos.yaml
Root pubspec.yaml adds a workspace listing member packages; melos config added/expanded with analyze and test scripts and versioning settings; melos.yaml receives a top-line deprecation notice for melos 7.x users.
Development infrastructure updates
.gitignore
Removed pubspec.lock from ignore rules so the lockfile can be committed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • serverpod/cli_tools#38: Modifies CI Dart SDK matrix and adjusts Dart 3.3-specific test handling in related files.

Suggested reviewers

  • Isakdl
  • SandPod
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the two main changes: bumping minimum Dart to 3.6 and introducing a Dart workspace, which are directly reflected in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-progress

Comment @coderabbitai help to get the list of available commands and usage tips.

@christerswahn christerswahn force-pushed the fix-progress branch 3 times, most recently from d54ee26 to 836261b Compare May 29, 2026 11:48
@christerswahn christerswahn changed the title chore: Bump minimum Dart SDK version to 3.5 chore: Bump min Dart to 3.6; introduced Dart workspace May 29, 2026
@christerswahn christerswahn marked this pull request as ready for review May 29, 2026 11:52
@christerswahn christerswahn requested a review from nielsenko May 29, 2026 11:52
Copy link
Copy Markdown
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Two suggestions, but nothing critical

Comment thread .github/workflows/ci.yml Outdated
Comment thread pubspec.yaml Outdated
@christerswahn christerswahn merged commit f42232d into main May 29, 2026
11 of 12 checks passed
@christerswahn christerswahn deleted the fix-progress branch May 29, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants