-
Notifications
You must be signed in to change notification settings - Fork 3
refactor: Reorganized files in new subdir packages/cli_tools #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe CI and publish workflows for the Dart CLI tools package were updated. The CI workflow now uses a matrix for package names and runs commands within the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
d76821b to
6c46981
Compare
6c46981 to
f2a9d33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
packages/cli_tools/pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.github/workflows/ci.yml(1 hunks).github/workflows/publish-cli_tools.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: for this project, avoid review comments that simply repeat compile-time errors the dart analyzer alr...
Learnt from: christerswahn
PR: serverpod/cli_tools#47
File: lib/src/config/options.dart:552-567
Timestamp: 2025-06-12T14:55:38.006Z
Learning: For this project, avoid review comments that simply repeat compile-time errors the Dart analyzer already reports; focus on issues not caught by the analyzer.
Applied to files:
.github/workflows/ci.yml
🔇 Additional comments (3)
.github/workflows/publish-cli_tools.yaml (1)
14-15: Confirmworking-directoryis a supported input of the reusable workflow
dart-lang/setup-dart/.github/workflows/publish.yml@v1must expose an input namedworking-directory; otherwise this job will fail with
inputs.working-directory: unknown input.
Please double-check the upstream workflow definition or pin to a commit that contains that input..github/workflows/ci.yml (2)
17-17: Good forward-looking addition ofpackagematrixIntroducing a
packagedimension makes the workflow ready for future multi-package support without impacting current behaviour.
24-27: Repetition unavoidable – nothing to fixDuplicating
working-directory: packages/${{ matrix.package }}per step is required because
defaults.run.working-directorydoes not allow expression interpolation.
Implementation is correct as-is.Also applies to: 41-44, 58-60
SandPod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Given my comments are addressed.
In preparation to house multiple packages in the cli_tools repo, this moves all the current package's files into a new subdirectory
packages/cli_tools. This enables other packages to be added.Summary by CodeRabbit