-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Add force parameter to server close() method #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a force parameter (default: false) to the close() method that allows immediate shutdown with forceful termination of in-flight requests. When force is false (default), the server waits for in-flight requests to complete before closing. When force is true, the server immediately closes and forcefully terminates remaining connections.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis PR adds a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 27.95% 27.95%
=======================================
Files 87 87
Lines 3291 3291
Branches 1735 1735
=======================================
Hits 920 920
Misses 2371 2371 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcelomendoncasoares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Description
Adds a
forceparameter (default:false) to theclose()method that allows immediate shutdown with forceful termination of in-flight requests.force: false(default): waits for in-flight requests to complete before closingforce: true: immediately closes and forcefully terminates remaining connectionsAdapter,IOAdapter, and allRelicServerimplementationsExample usage:
Related Issues
Pre-Launch Checklist
///), ensuring consistency with existing project documentation.Breaking Changes
Additional Notes
The
forceparameter maps directly to Dart'sHttpServer.close(force:)parameter. This is useful for self-hosted deployments where container orchestration behavior may vary, or when long-running requests should not delay server shutdown indefinitely.Summary by CodeRabbit
New Features
forceparameter to server shutdown, enabling immediate termination of all in-flight requests instead of waiting for graceful completion.Tests
✏️ Tip: You can customize this high-level summary in your review settings.