docs: Add an example of custom runtime parameters extending the builder#306
Conversation
📝 WalkthroughWalkthroughThe documentation for Serverpod's runtime parameters was updated to introduce a third method for creating custom runtime parameter groups. This new approach involves extending the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant RuntimeParametersBuilder
participant CustomRuntimeParameters
Developer->>RuntimeParametersBuilder: call extension method (e.g., classCustomParameters)
RuntimeParametersBuilder-->>CustomRuntimeParameters: instantiate with custom params
CustomRuntimeParameters-->>Developer: return custom runtime parameters instance
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/06-concepts/06-database/12-runtime-parameters.md (1)
156-158: Clarify import forCustomRuntimeParameters.The extension snippet only imports
package:serverpod/database.dart, but to useCustomRuntimeParametersyou must also import (or define in the same file) the module whereCustomRuntimeParametersis declared.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/06-concepts/06-database/12-runtime-parameters.md(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test build
🔇 Additional comments (4)
docs/06-concepts/06-database/12-runtime-parameters.md (4)
104-104: Updated phrasing is clear and inclusive of the new method.Changing “one of two ways” to “the following ways” accurately reflects the addition of a third approach.
129-129: Heading description is concise and accurate.The instruction to extend
RuntimeParameterswith an overriddenoptionsgetter is clear.
151-151: Sub-heading aligns with existing structure.Using “Extending the builder class with custom methods” matches the style of the other examples.
153-153: Introduction sentence succinctly explains the new example.Readers will understand they’re adding extension methods to the builder.
Address the pending comment from PR #296.
Summary by CodeRabbit