Provide a package selection dialog when installing skills#17
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
jakemac53
force-pushed
the
choose-install-packages
branch
from
88bd3a5 to
5ffeba2
Compare
Collaborator
Author
|
cc @kenzieschmoll can you review this one as well |
| logger.info(' $pkg'); | ||
| } | ||
| logger.info('Rerun with trailing arguments for each package you want ' | ||
| 'to install skills for, or `all` to install all skills.'); |
There was a problem hiding this comment.
if there is no dialogSupport, should we just default to all to mimic the previous behavior of skills get?
Collaborator
Author
There was a problem hiding this comment.
I don't think so - I want that to be more explicit personally. We do have the all special argument to handle this case.
Primarily this is here for agentic usage and I think this message should help agents in terms of choosing which skills to actually install on the next call. Maybe they will just pass all, or maybe they will be a bit more direct, but it forces a choice.
kenzieschmoll
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides not only a bit more transparency into what exactly is being installed, but also lets you pick and choose which packages skills you ultimately do install. If packages are explicitly given, the dialog is skipped.
allpackage name that just means install for all packages.DialogSupport.showMultiSelectmethod to take a set of initially selected indicesCloses dart-lang/ai#457