fpm-apache: is mod_expires left out on purpose?

[twiesing]

The fpm-apache variation enables actions autoindex deflate headers http2 proxy proxy_fcgi remoteip rewrite setenvif ssl unique_id, but not expires, although expires.load is in mods-available.

We run WordPress sites on 8.5-fpm-apache. One of them has the usual <IfModule mod_expires.c> block in its .htaccess, which Apache skips silently, so its images go out without Cache-Control.

Is leaving it out on purpose? If not, would you take a PR that adds expires to the list? For now we run a2enmod expires in our own image.

[XNinety9]

From the history it doesn't look deliberate: the a2enmod line in src/variations/fpm-apache/Dockerfile hasn't changed since fpm-apache was added (2b9c100, Feb 2024). When static-asset caching was added in #487, it only went into the nginx variation (Cache-Control: public, max-age=31536000, immutable in server-opts.d/performance.conf). There's no equivalent on the Apache side, so a PR adding expires (or matching #487 for Apache) seems in line with that.

In the meantime, if you'd rather not maintain a derived image: headers is already enabled and AllowOverride All is set in the vhost, so this in .htaccess works on the stock image:

<IfModule mod_headers.c>
  <FilesMatch "\.(gif|jpe?g|png|webp|svg|css|js|woff2?)$">
    Header set Cache-Control "public, max-age=31536000"
  </FilesMatch>
</IfModule>

I checked on serversideup/php:8.5-fpm-apache: with only the mod_expires.c block, a .gif comes back without any cache header (expires.load is in mods-available, not mods-enabled). With the block above, it gets Cache-Control: public, max-age=31536000.

[twiesing]

#734