Canonic member #15
Merged
Canonic member #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botinko
reviewed
Jul 7, 2020
| public override int GetHashCode() | ||
| { | ||
| unchecked { | ||
| return (module.GetHashCode() * 397) ^ metadataToken; |
There was a problem hiding this comment.
suggest HashCode.Combine(module, metadataToken)
Author
There was a problem hiding this comment.
I'd perform perf testing first to identify best option.
commit-n-run
reviewed
Jul 9, 2020
| case ConflictHandlingMethod.ReportError: | ||
| compilers.MergeWith(newItems, true); | ||
| break; | ||
| foreach (var (targetMember, compiler) in newRegistrations) { |
There was a problem hiding this comment.
This changes behavior, previous version performed atomic merge, new one merges items one by one.
AlexUstinov
added a commit
that referenced
this pull request
Aug 10, 2020
Eliminate GetGenericMethodDefinition method call in MemberCompilerProvider class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we remove
GetGenericMethodDefinitioncall frequently called during query translation