Optimizing refactoring: use ArraySegment instead of allocating subarray#33
Merged
SergeiPavlov merged 2 commits intomaster-servicetitanfrom Aug 31, 2021
Merged
Conversation
botinko
approved these changes
Aug 26, 2021
SergeiPavlov
added a commit
that referenced
this pull request
Dec 14, 2021
…ay (#33) * Optimizing refactoring: use ArraySegment instead of allocating subarray * Copyright lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optimization is here: https://github.com/servicetitan/dataobjects-net/pull/33/files#diff-03168b160ac9646b7cc14af6934909caecdf6213f68d91386277c3ace0a29ab9L90
Convert some methods to
IReadOnlyListargument because it allows to useArraySegment