Optimizing refactoring: make TranslatorState struct #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexUstinov
reviewed
Oct 1, 2021
botinko
approved these changes
Oct 5, 2021
AlexUstinov
reviewed
Oct 5, 2021
AlexUstinov
approved these changes
Oct 5, 2021
SergeiPavlov
added a commit
that referenced
this pull request
Oct 6, 2021
* Optimizing refactoring: make TranslatorState struct * Use 'in' modifier with TranslatorState passing * Use 'in' modifier in TranslatorState constructor
SergeiPavlov
pushed a commit
that referenced
this pull request
Oct 25, 2021
…rState Optimizing refactoring: make TranslatorState struct (#41)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
TranslatorStatereadonly struct to avoid allocationsI'm suggesting to change
TranslatorState.flagsbit-field to 10boolfields.The struct will be 8 byte-longer, but simpler and faster
@AlexUstinov what do you think?