Skip to content

Conversation

@Narfinger
Copy link
Contributor

@Narfinger Narfinger commented May 16, 2025

Update hitrace version for new filters.
Originally we used Load Status change started but that does not seem to be emitted anymore. So we changed to HeadParsed.
The changes to hitrace-bench can be seen here: openharmony-rs/hitrace-bench@416472e

Ideally we probably want to read the filters from a file in the future.

I tested these changes on the OHOS spare infrastructure.

@jschwe
Copy link
Member

jschwe commented May 16, 2025

Originally we used Load Status change started but that does not seem to be emitted anymore. So we changed to HeadParsed.

Lets use a self-defined string in servoshell for the event name instead of using the Debug implementation (since that can change without us noticing). If we match on the enum, we will / CI will notice name changes.

@Narfinger
Copy link
Contributor Author

While this is probably a good idea, the current problem seems to be that LoadStatus::Started is never send.

@Narfinger Narfinger closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants