Avoid panics when calling into dwrote
#260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
approved these changes
Mar 10, 2025
mrobinson
changed the title
dwrote
Member
|
I think this will also need to bump the version of |
mrobinson
previously requested changes
Mar 10, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Please increase the dwrote dependency version (might require a new release there) and also update the commit title to match the new PR title.
acarl005
force-pushed
the
andy/fallible-directwrite-1
branch
from
3372aeb to
2978461
Compare
Contributor
Author
|
I've updated the commit message per the new title. I don't think there's a published version with the required changes, so I've updated the |
Member
|
Waiting on servo/dwrote-rs#65 so I can publish a new version. |
Member
|
dwrote 0.11.3 is on crates.io. |
jdm
approved these changes
Mar 29, 2025
acarl005
added a commit
to warpdotdev/font-kit
that referenced
this pull request
Sep 26, 2025
acarl005
added a commit
to warpdotdev/font-kit
that referenced
this pull request
Sep 26, 2025
…ssertions-panicking Avoid panics when calling into `dwrote` (servo#260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some panicking code paths from the directwrite wrappers.
It builds off of servo/dwrote-rs#62 to consume the new fallible methods that result
Resultsinstead of panicking. Note that it needs a version bump in theCargo.tomlonce that is published.I also have servo/dwrote-rs#63 open so I can migrate more calls if that one lands.