Skip to content

Conversation

@Loirooriol
Copy link
Contributor

Bumps html5ever, markup5ever and xml5everf to 0.36.0.
Bumps web_atoms to 0.1.4.

Bumps html5ever, markup5ever and xml5everf to 0.36.0.
Bumps web_atoms to 0.1.4.

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
@Loirooriol Loirooriol added this pull request to the merge queue Nov 11, 2025
Merged via the queue into servo:main with commit 494ca07 Nov 11, 2025
8 checks passed
@Loirooriol Loirooriol deleted the bump-version branch November 11, 2025 06:04
@mrobinson
Copy link
Member

@xu-cheng
Copy link
Contributor

Hi, according to this, it seems that web_atoms should be bumped to 0.2.0 instead due to phf breaking change from #654. The 0.1.4 release may need to be yanked.

@Loirooriol
Copy link
Contributor Author

Loirooriol commented Nov 11, 2025

Even if phf had potentially breaking changes, I don't think that web_atoms had any, so I thought that a 0.1.4 was enough?

@xu-cheng
Copy link
Contributor

I’m actually not entirely sure what is the correct answer.

The question is what would happen if old html5ever release pulls the latest web_atom of which a breaking release phf is used underneath. The breaking release phf may cause trait conflicts or inconsistent hash being used. But since html5ever itself does not depend on phf directly. It may be fine? 🤷‍♂️

@Loirooriol
Copy link
Contributor Author

No problem from my side if you want to bump to 0.2.0

@jdm
Copy link
Member

jdm commented Nov 11, 2025

Yes, we'll need to yank and publish 0.2.0 instead.

@nicoburns
Copy link
Contributor

I can confirm that the Blitz build does actually break if I run cargo update (which causes it to pick up web_atoms 0.1.4), so we definitely need to republish and yank this release. I've put up #691 with new versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants