Handle encoding indicators in the driver module#717
Merged
simonwuelker merged 2 commits intoservo:mainfrom Jan 19, 2026
Merged
Conversation
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
simonwuelker
commented
Jan 17, 2026
Comment on lines
+26
to
+32
| impl TreeSink for Sink { | ||
| type Handle = usize; | ||
| type Output = Self; | ||
| type ElemName<'a> = ExpandedName<'a>; | ||
| fn finish(self) -> Self { | ||
| self | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This sink implementation is copied from one of the examples
mrobinson
approved these changes
Jan 19, 2026
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
simonwuelker
force-pushed
the
driver-fix
branch
from
d1db67a to
b1ec495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #716