Merged
Conversation
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
sagudev
approved these changes
Jan 13, 2026
Member
sagudev
left a comment
sagudev
left a comment
There was a problem hiding this comment.
Specification by tests is better then no specification at all.
Co-authored-by: Sam <16504129+sagudev@users.noreply.github.com> Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
glyn
approved these changes
Jan 15, 2026
Contributor
glyn
left a comment
glyn
left a comment
There was a problem hiding this comment.
This is good, thanks. I've suggested a couple of improvements, but these could also go in a subsequent PR, as could a corresponding docs change.
Co-authored-by: Glyn Normington <work@underlap.org> Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Contributor
Author
|
Ok I also added one explanation to make sure that nobody is confused by the later check for Disconnected. |
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
glyn
reviewed
Jan 15, 2026
glyn
approved these changes
Jan 15, 2026
Contributor
glyn
left a comment
glyn
left a comment
There was a problem hiding this comment.
Looking good now, thanks. One more suggestion to clarify the comment.
Co-authored-by: Glyn Normington <work@underlap.org> Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test for dropping the sender when a message is not received yet.
Currently this behavior was unspecified and untested. This gives us now an expected behavior.
Signed-off-by: Narfinger Narfinger@users.noreply.github.com