Skip to content

Gate pull requests on mozjs-sys bump if there are any C++ changes #601

@delan

Description

@delan

in #595, we made Servo-breaking changes in mozjs-sys without bumping the mozjs-sys crate version, which meant that no new artifact was released for prebuilt mozjs. this broke Servo in servo/servo#38311.

we should prevent pull requests from merging if they have any changes (or at least any C++ changes?) in mozjs-sys without bumping the version. this can be done in build.yml’s integrity job.

(zulip thread, cc @sagudev)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions