Skip to content

Conversation

@sagudev
Copy link
Member

@sagudev sagudev commented Jul 28, 2025

Fixes #601

To avoid problems we should also enable "Require branches to be up to date before merging" in GitHub for this repo: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#require-status-checks-before-merging

Testing:

@sagudev sagudev force-pushed the ensure_bump branch 3 times, most recently from 979f10b to a610d70 Compare July 28, 2025 09:31
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev sagudev marked this pull request as ready for review July 28, 2025 09:44
@sagudev sagudev requested a review from delan July 28, 2025 09:44
Copy link
Member

@delan delan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this so quickly! how come only C++ changes require a version bump? do the artifacts not contain any of the rust parts of mozjs-sys?

@sagudev
Copy link
Member Author

sagudev commented Jul 28, 2025

how come only C++ changes require a version bump? do the artifacts not contain any of the rust parts of mozjs-sys?

Artifacts contain compiled SM (so all C/C++ code), all glues (src/*.cpp) and generated rust bindings of them, hence I also included mozjs-sys/* in filter to catch changes to build.rs (defines how artifacts are packed) and Cargo.toml (defines bindgen version).
Rust parts are always recompiled, as they are fast enough to compile and rust does not have stable ABI.

@sagudev sagudev added this pull request to the merge queue Jul 28, 2025
Merged via the queue into servo:main with commit 6c2b02f Jul 28, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gate pull requests on mozjs-sys bump if there are any C++ changes

2 participants