Skip to content

Conversation

@hsivonen
Copy link
Contributor

@hsivonen hsivonen commented Aug 28, 2017

Update to the latest encoding_rs. The changes along the way don't appear to affect this crate.


This change is Reviewable

@SimonSapin
Copy link
Member

encoding_rs is only used in this repo for tests (it’s in dev-dependencies) so it shouldn’t affect downstream users. But thanks anyway!

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 3f09de5 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit 3f09de5 with merge 17d2a1d...

bors-servo pushed a commit that referenced this pull request Aug 28, 2017
Update encoding_rs to 0.7.0

Update to the latest encoding_rs. The changes along the way don't appear to affect this crate.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/188)
<!-- Reviewable:end -->
@SimonSapin
Copy link
Member

Stylo’s code (affecting what’s vendored in gecko) using encoding_rs is here: https://github.com/servo/servo/blob/master/components/style/encoding_support.rs

@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing 17d2a1d to master...

@bors-servo bors-servo merged commit 3f09de5 into servo:master Aug 28, 2017
@SimonSapin
Copy link
Member

Looks like I forgot to rename Servo’s RustEncoding struct to EncodingRs when switch implementations…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants