Test encoding of URL params #1083
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently
Url::parseandUrl::parse_with_paramsdo different things leading to a different encoding and therefore string rep.In
Url::parse,:is preserved across params. That's not the case when usingparse_with_paramswhich internally usesquery_pairs_mut.I'm not sure which is correct in the general case. If i understand RFC 3986 they should be encoded in all cases, except when the protocol specifies it.
This PR only contains tests as i'm not familiar with url crate internals.