Include username and password in Url's Debug implementation #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Dec 10, 2020
Contributor
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Ah, that explains some surprising things I saw recently. Thanks!
Contributor
Author
|
CI seems to be broken on coverage. Don't think it's related to this PR. |
valenting
requested changes
Dec 10, 2020
Collaborator
valenting
left a comment
valenting
left a comment
There was a problem hiding this comment.
I think those fields should go in the appropriate position - after the scheme?
Contributor
Author
|
I have no strong opinion on the order. Moved them to your suggested position. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into improving fuzzing I noticed that these two fields are missing which can make it confusing when two urls aren't equal but their debug is equal.