Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Support a restyle hint that indicates all descendants must be recascaded. #17087

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
5 participants
@heycam
Copy link
Member

commented May 30, 2017

This also moves the result of deciding whether to recascade from the RestyleData into the RestyleHint.

Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1367647.


This change is Reviewable

style: Support a restyle hint that indicates all descendants must be …
…recascaded.

This also moves the result of deciding whether to recascade from the
RestyleData into the RestyleHint.
@highfive

This comment has been minimized.

Copy link

commented May 30, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/data.rs, components/style/restyle_hints.rs, components/style/traversal.rs
  • @emilio: components/style/data.rs, components/style/restyle_hints.rs, components/style/traversal.rs
@highfive

This comment has been minimized.

Copy link

commented May 30, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@heycam

This comment has been minimized.

Copy link
Member Author

commented May 30, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

📌 Commit d0d4370 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

⌛️ Testing commit d0d4370 with merge aa4aef3...

bors-servo added a commit that referenced this pull request May 30, 2017

Auto merge of #17087 - heycam:recascade, r=emilio
style: Support a restyle hint that indicates all descendants must be recascaded.

This also moves the result of deciding whether to recascade from the RestyleData into the RestyleHint.

Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1367647.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

@bors-servo bors-servo merged commit d0d4370 into servo:master May 30, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.