Skip to content

style: Support a restyle hint that indicates all descendants must be recascaded. #17087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2017
Merged

style: Support a restyle hint that indicates all descendants must be recascaded. #17087

merged 1 commit into from
May 30, 2017

Conversation

@heycam
Copy link
Contributor

@heycam heycam commented May 30, 2017 •
edited by larsbergstrom
Loading

This also moves the result of deciding whether to recascade from the RestyleData into the RestyleHint.

Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1367647.

This change is Reviewable

@heycam
style: Support a restyle hint that indicates all descendants must be …
d0d4370 
…recascaded.

This also moves the result of deciding whether to recascade from the
RestyleData into the RestyleHint.
@highfive highfive assigned ghost May 30, 2017
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/data.rs, components/style/restyle_hints.rs, components/style/traversal.rs
  • @emilio: components/style/data.rs, components/style/restyle_hints.rs, components/style/traversal.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 30, 2017
@heycam
Copy link
Contributor Author

heycam commented May 30, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit d0d4370 has been approved by emilio

@highfive highfive assigned emilio and unassigned ghost May 30, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 30, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit d0d4370 with merge aa4aef3...

bors-servo pushed a commit that referenced this pull request May 30, 2017
Auto merge of #17087 - heycam:recascade, r=emilio
aa4aef3 
style: Support a restyle hint that indicates all descendants must be recascaded.

This also moves the result of deciding whether to recascade from the RestyleData into the RestyleHint.

Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1367647.
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing aa4aef3 to master...

@bors-servo bors-servo merged commit d0d4370 into servo:master May 30, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emilio emilio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@heycam @highfive @bors-servo @emilio