Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WR multi-document update #17892

Merged
merged 1 commit into from Jul 28, 2017

Conversation

Projects
None yet
8 participants
@kvark
Copy link
Member

commented Jul 27, 2017

The PR updates WR version to support multiple documents (servo/webrender#1509) but doesn't take advantage of this new feature yet.
It also makes Servo to use DevicePixel from WR instead of rolling out another one.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____ no extra logic

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jul 27, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/pipeline.rs, components/constellation/constellation.rs
  • @fitzgen: components/script_traits/lib.rs, components/script_traits/lib.rs
  • @KiChjang: components/script_traits/lib.rs, components/script_traits/lib.rs
@glennw

This comment has been minimized.

Copy link
Member

commented Jul 27, 2017

Nice!

@bors-servo r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

📌 Commit 640a953 has been approved by glennw

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

⌛️ Testing commit 640a953 with merge 7b492d7...

bors-servo added a commit that referenced this pull request Jul 27, 2017

Auto merge of #17892 - kvark:wr, r=glennw
WR multi-document update

<!-- Please describe your changes on the following line: -->
The PR updates WR version to support multiple documents (servo/webrender#1509) but doesn't take advantage of this new feature yet.
It also makes Servo to use `DevicePixel` from WR instead of rolling out another one.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____ no extra logic

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17892)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2017

💔 Test failed - mac-dev-unit

@jdm

This comment has been minimized.

Copy link
Member

commented Jul 27, 2017

./mach build-cef needs to be fixed.

@kvark kvark force-pushed the kvark:wr branch from 640a953 to 6286aca Jul 28, 2017

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2017

Thanks @jdm !
@bors-servo r=glennw

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2017

📌 Commit 6286aca has been approved by glennw

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2017

⌛️ Testing commit 6286aca with merge d945466...

bors-servo added a commit that referenced this pull request Jul 28, 2017

Auto merge of #17892 - kvark:wr, r=glennw
WR multi-document update

<!-- Please describe your changes on the following line: -->
The PR updates WR version to support multiple documents (servo/webrender#1509) but doesn't take advantage of this new feature yet.
It also makes Servo to use `DevicePixel` from WR instead of rolling out another one.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____ no extra logic

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17892)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2017

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2017

@mrobinson

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2017

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

This feels like WR has broken some webgl feature.

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2017

@jdm it is quite possible, since I was re-arranging WebGL flushes.
I'll do another pass to see if the logic has changed.
cc @MortimerGoro - want to check out servo/webrender#1509 ?

@MortimerGoro

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2017

@kvark I think that the problem is that current_bound_webgl_context_id gets dirty after a flush_webgl(). Try setting current_bound_webgl_context_id to None.

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2017

@MortimerGoro yep, I saw that. Should be fixed by servo/webrender#1530

@kvark kvark force-pushed the kvark:wr branch from 6286aca to 8c588e8 Jul 28, 2017

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2017

No code changes to this PR, just getting past the WebGL PR in WR that is supposed to fix the issues here.
@bors-servo r=glennw

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2017

📌 Commit 8c588e8 has been approved by glennw

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2017

⌛️ Testing commit 8c588e8 with merge 12a49dc...

bors-servo added a commit that referenced this pull request Jul 28, 2017

Auto merge of #17892 - kvark:wr, r=glennw
WR multi-document update

<!-- Please describe your changes on the following line: -->
The PR updates WR version to support multiple documents (servo/webrender#1509) but doesn't take advantage of this new feature yet.
It also makes Servo to use `DevicePixel` from WR instead of rolling out another one.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____ no extra logic

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17892)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2017

@bors-servo bors-servo merged commit 8c588e8 into servo:master Jul 28, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors-servo bors-servo referenced this pull request Jul 28, 2017

Merged

Script paint worklets speculative evaluation #17810

4 of 4 tasks complete

@kvark kvark deleted the kvark:wr branch Jul 28, 2017

moz-servo-sync added a commit to moz-servo-sync/servo that referenced this pull request Jul 28, 2017

bors-servo added a commit that referenced this pull request Jul 28, 2017

Auto merge of #17910 - moz-servo-sync:gecko-backout, r=moz-servo-sync
Multiple gecko backouts

Backed out changeset a417b9d7712d for vendoring bustage. r=backout on a CLOSED TREE

Backs out #17565

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17910)
<!-- Reviewable:end -->

---

Backed out changeset c424ad1c5f94 for build failures a=backout CLOSED TREE

Backs out #17892

@kvark kvark referenced this pull request Jul 29, 2017

Merged

WR multi-document update - try 2 #17908

3 of 5 tasks complete

bors-servo added a commit that referenced this pull request Jul 29, 2017

Auto merge of #17908 - kvark:wr, r=emilio
WR multi-document update - try 2

<!-- Please describe your changes on the following line: -->
Combines #17892 with the patch to detach style_traits from webrender_api

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix  #17907

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____ new logic is added

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17908)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.