New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taskcluster: add dev build and unit tests on macOS #22185

Merged
merged 10 commits into from Nov 15, 2018

Conversation

Projects
None yet
5 participants
@SimonSapin
Member

SimonSapin commented Nov 12, 2018

For simplicity, Salt is used in agentless mode for now.

I’m also hoping to have most of the dependencies be installed by tasks for themselves, so that changes can be made in the same servo/servo PR that uses them without redeploying servers.


This change is Reviewable

@@ -0,0 +1,2 @@
salt-ssh:
config_dir: ./config

This comment has been minimized.

@Manishearth

Manishearth Nov 12, 2018

Member

missing newlines at eof for most of these files

This comment has been minimized.

@SimonSapin
file.managed:
- mode: 644
- template: jinja
- contents: >-

This comment has been minimized.

@Manishearth

Manishearth Nov 12, 2018

Member

is it possible to store this file separately?

i suppose the substs make this harder

nah, we use files with substs in our current salt setup: https://github.com/servo/saltfs/blob/master/homu/init.sls#L69

This comment has been minimized.

@SimonSapin
- contents: |-
#!/bin/sh
# generic-worker overwrites its config file to fill in defaults,
# but we want to avoid touching config.json here

This comment has been minimized.

@Manishearth

Manishearth Nov 12, 2018

Member

try to split this into its own file if possible

This comment has been minimized.

@SimonSapin

SimonSapin Nov 12, 2018

Member

Removed as part of another change.

* Add a correponding entry in the `config/roster` file.
* Log in through VNC, and run `xcode-select --install`

This comment has been minimized.

@jdm

jdm Nov 13, 2018

Member

https://github.com/servo/servo/wiki/SaltStack-Administration has a number of other steps we follow right now.

This comment has been minimized.

@SimonSapin

SimonSapin Nov 14, 2018

Member

I’m hoping to make some of those taken care of by Salt or by tasks, but installing XCode requires GUI interaction.

This comment has been minimized.

@SimonSapin

SimonSapin Nov 15, 2018

Member

Also, this document is intended to expand over time as we do more, it is not at an end state. This is documenting what I’ve done so far and how to reproduce it.

@SimonSapin SimonSapin changed the title from Add SaltStack configuration for macOS Taskcluster workers to Taskcluster: add dev build and unit tests on macOS Nov 15, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 15, 2018

☔️ The latest upstream changes (presumably #22201) made this pull request unmergeable. Please resolve the merge conflicts.

@SimonSapin SimonSapin force-pushed the tc-mac branch from 58f763d to 1c7dbe1 Nov 15, 2018

@Manishearth

r=me

@SimonSapin

This comment has been minimized.

Member

SimonSapin commented Nov 15, 2018

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 15, 2018

📌 Commit 1c7dbe1 has been approved by Manishearth

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 15, 2018

⌛️ Testing commit 1c7dbe1 with merge b8281b4...

bors-servo added a commit that referenced this pull request Nov 15, 2018

Auto merge of #22185 - servo:tc-mac, r=Manishearth
Taskcluster: add dev build and unit tests on macOS

For simplicity, Salt is used in [agentless](https://docs.saltstack.com/en/getstarted/ssh/) mode for now.

I’m also hoping to have most of the dependencies be installed by tasks for themselves, so that changes can be made in the same `servo/servo` PR that uses them without redeploying servers.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22185)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 15, 2018

💔 Test failed - mac-rel-css2

@SimonSapin

This comment has been minimized.

Member

SimonSapin commented Nov 15, 2018

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/unloading-documents/unload/004.html:
  │ FAIL [expected PASS] pagehide / unload event order
  │   → assert_array_equals: lengths differ, expected 2 got 3
  │ 
  │ onload/</iframe.onload/iframe.onload<@http://web-platform.test:8000/html/browsers/browsing-the-web/unloading-documents/unload/004.html:19:51
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1568:20
  └ Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1592:20

@bors-servo retry

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 15, 2018

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 15, 2018

@bors-servo bors-servo merged commit 1c7dbe1 into master Nov 15, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the tc-mac branch Nov 15, 2018

@SimonSapin SimonSapin referenced this pull request Nov 30, 2018

Open

Meta: move CI from Buildbot to Taskcluster #22325

12 of 24 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment