Partial ShadowDOM support #22743

ferjm · 2019-01-22T15:28:13Z

This is just an early WIP, not to take it very seriously yet.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Implement partial Shadow DOM support (for User Agent UI widgets) #22719
There are tests for these changes

This change is

highfive · 2019-01-22T15:28:18Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/document.rs, components/script/dom/shadowroot.rs, components/script/dom/macros.rs, components/script/dom/node.rs, components/script/dom/element.rs and 9 more
@KiChjang: components/script/dom/document.rs, components/script/dom/shadowroot.rs, components/script/dom/macros.rs, components/script/dom/node.rs, components/script/dom/element.rs and 9 more

highfive · 2019-01-22T15:28:20Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify script code, but no tests are modified. Please consider adding a test!

components/script/dom/htmlcollection.rs

emilio · 2019-01-24T11:50:46Z

components/script/dom/macros.rs

+            let x = *x as f32;
+            let y = *y as f32;
+            let point = &Point2D::new(x, y);
+            let viewport = self.window.window_size().initial_viewport;


This needs to retarget nodes in shadow trees and such... Rather than having these implementations duplicated I would have them just in DocumentOrShadowRoot, which also avoids having to implement dummy ShadowRoot::GetBody & co.

components/script/dom/htmlcollection.rs

emilio · 2019-01-24T11:56:51Z

Also, I'm pretty sure you need a flag to know when a node is connected, and replace a bunch of uses of IS_IN_DOCUMENT by that. Also you need to audit all the callers that propagate flags around the tree like the layout dirty flags and change them so they not only look at parent_node but at parent_node_crossing_shadow_root or something

ferjm · 2019-01-25T12:07:50Z

Also, I'm pretty sure you need a flag to know when a node is connected, and replace a bunch of uses of IS_IN_DOCUMENT by that

I ended up setting the IS_IN_DOC flag if the node is connected, which I think is essentially the same thing and saves us from replacing some of the uses of IS_IN_DOC by IS_CONNECTED.

emilio · 2019-01-25T12:58:50Z

I'd rather not do that, there are some legit uses of IS_IN_DOC / is_in_doc that need to know whether you're on a document or not. Gecko used to do that and we had to rewrite it because there were too many bugs.

components/script/dom/node.rs

ferjm · 2019-02-13T16:06:09Z

The shadow tree is now rendered and styled. Shadow tree styles still affect the document though.

ferjm · 2019-02-13T17:25:04Z

The last commit fixes the fact that shadow tree styles were applied to the document.

ferjm · 2019-02-18T16:50:35Z

@bors-servo try=wpt

bors-servo · 2019-02-18T16:50:41Z

⌛ Trying commit 6809f58 with merge 819191c...

[WIP] Partial ShadowDOM support This is just an early WIP, not to take it very seriously yet. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) - [ ] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22743)

bors-servo · 2019-02-18T17:11:14Z

💔 Test failed - linux-rel-css

components/script/dom/element.rs

ferjm · 2019-02-19T18:01:09Z

@bors-servo try=wpt

[WIP] Partial ShadowDOM support This is just an early WIP, not to take it very seriously yet. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) - [ ] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22743)

bors-servo · 2019-02-19T18:02:08Z

⌛ Trying commit cc1fdf8 with merge 9d8d0df...

ferjm · 2019-04-29T10:36:43Z

Thanks for bearing with me, and sorry it took quite long :)

Thank you for your mentoring and patient :)

ferjm · 2019-04-29T10:40:25Z

@bors-servo r=emilio

bors-servo · 2019-04-29T10:40:26Z

📌 Commit 37e88e7 has been approved by emilio

bors-servo · 2019-04-29T10:56:40Z

⌛ Testing commit 37e88e7 with merge 30ded91...

Partial ShadowDOM support This is just an early WIP, not to take it very seriously yet. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #22719 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22743)

bors-servo · 2019-04-29T11:20:14Z

💔 Test failed - linux-rel-css

ferjm · 2019-04-29T12:19:00Z

@bors-servo retry

bors-servo · 2019-04-29T12:38:47Z

💣 Failed to start rebuilding: Unknown error

bors-servo · 2019-04-29T12:38:52Z

⌛ Testing commit 37e88e7 with merge 799490a...

Partial ShadowDOM support This is just an early WIP, not to take it very seriously yet. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #22719 - [x] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22743)

bors-servo · 2019-04-29T14:45:24Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: emilio
Pushing 799490a to master...

Media controls <strike>This is still highly WIP. It depends on #22743 and so it is based on top of it. The basic controls functionality is there, but the layout is highly broken. There is a hack to at least make the controls render on top of the video, but it is not correctly positioned. The controls' div container ends up as sibbling of the media element in the flow tree while IIUC it should end up as a child.</strike> - [X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [X] These changes fix #22721 and #22720 There is at least an extra dependency to improve the functionality and visual aspect: #22728.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23208)

Media controls <strike>This is still highly WIP. It depends on #22743 and so it is based on top of it. The basic controls functionality is there, but the layout is highly broken. There is a hack to at least make the controls render on top of the video, but it is not correctly positioned. The controls' div container ends up as sibbling of the media element in the flow tree while IIUC it should end up as a child.</strike> - [X] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [X] These changes fix #22721 and fix #22720 There is at least an extra dependency to improve the functionality and visual aspect: #22728.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23208)

highfive assigned SimonSapin Jan 22, 2019

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 22, 2019

ferjm removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 22, 2019

ferjm unassigned SimonSapin Jan 22, 2019

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 23, 2019

emilio reviewed Jan 23, 2019

View reviewed changes

components/script/dom/htmlcollection.rs Outdated Show resolved Hide resolved

emilio reviewed Jan 24, 2019

View reviewed changes

ferjm force-pushed the shadowdom branch from f2857c7 to 950c2e3 Compare January 24, 2019 17:16

ferjm changed the title ~~[WIP] Partial ShadowDOM support: ShadowRoot~~ [WIP] Partial ShadowDOM support Jan 24, 2019

emilio reviewed Jan 27, 2019

View reviewed changes

components/script/dom/node.rs Outdated Show resolved Hide resolved

components/script/dom/node.rs Outdated Show resolved Hide resolved

components/script/dom/node.rs Show resolved Hide resolved

ferjm force-pushed the shadowdom branch from 53a0414 to ec5eee9 Compare February 1, 2019 15:35

ferjm force-pushed the shadowdom branch 2 times, most recently from 4da558b to a85b958 Compare February 15, 2019 13:56

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-tests-failed The changes caused existing tests to fail. labels Feb 18, 2019

emilio reviewed Feb 19, 2019

View reviewed changes

components/script/dom/element.rs Outdated Show resolved Hide resolved

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 29, 2019

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 29, 2019

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 29, 2019

bors-servo merged commit 37e88e7 into servo:master Apr 29, 2019

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 29, 2019

This was referenced Apr 29, 2019

StereoPannerNode DOM #23281

Merged

implement stylesheet.ownerNode #23096

Closed

Implement WheelEvent interface #23154

Merged

Implement PerformanceNavigation interface #23203

Merged

ferjm deleted the shadowdom branch April 30, 2019 13:29

ferjm mentioned this pull request Jun 18, 2019

Implement the Shadow DOM #9370

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Partial ShadowDOM support #22743

Partial ShadowDOM support #22743

ferjm commented Jan 22, 2019 •

edited

Loading

highfive commented Jan 22, 2019

highfive commented Jan 22, 2019

emilio Jan 24, 2019

emilio commented Jan 24, 2019

ferjm commented Jan 25, 2019

emilio commented Jan 25, 2019

ferjm commented Feb 13, 2019

ferjm commented Feb 13, 2019

ferjm commented Feb 18, 2019

bors-servo commented Feb 18, 2019

bors-servo commented Feb 18, 2019

ferjm commented Feb 19, 2019

bors-servo commented Feb 19, 2019

ferjm commented Apr 29, 2019

ferjm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

ferjm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

Partial ShadowDOM support #22743

Partial ShadowDOM support #22743

Conversation

ferjm commented Jan 22, 2019 • edited Loading

highfive commented Jan 22, 2019

highfive commented Jan 22, 2019

emilio Jan 24, 2019

Choose a reason for hiding this comment

emilio commented Jan 24, 2019

ferjm commented Jan 25, 2019

emilio commented Jan 25, 2019

ferjm commented Feb 13, 2019

ferjm commented Feb 13, 2019

ferjm commented Feb 18, 2019

bors-servo commented Feb 18, 2019

bors-servo commented Feb 18, 2019

ferjm commented Feb 19, 2019

bors-servo commented Feb 19, 2019

ferjm commented Apr 29, 2019

ferjm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

ferjm commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

bors-servo commented Apr 29, 2019

ferjm commented Jan 22, 2019 •

edited

Loading