Add referrer to navigation fetch request #23090

miller-time · 2019-03-25T06:26:57Z

Implement step 13 of following hyperlinks and step 14.3 of window open, as well as other referrer- and fetch-related updates.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Add "referrer" to fetch request used in navigation #22890 (GitHub issue number if applicable)

There are tests for these changes OR
These changes do not require tests because ___

This change is

highfive · 2019-03-25T06:27:04Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

highfive · 2019-03-25T06:27:04Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/windowproxy.rs, components/script/dom/htmlanchorelement.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script/dom/location.rs
@KiChjang: components/script/dom/windowproxy.rs, components/script/dom/htmlanchorelement.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/net_traits/request.rs and 2 more

highfive · 2019-03-25T06:27:06Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

gterzian · 2019-04-04T08:38:38Z

@bors-servo try=wpt

bors-servo · 2019-04-04T08:38:44Z

⌛ Trying commit e98db92 with merge 92a41b9...

Add referrer to navigation fetch request  Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22890 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)

gterzian · 2019-04-04T08:39:46Z

@miller-time Results from the tests will show up at https://build.servo.org/grid (look for the column matching the commits mentioned above by the bot)

bors-servo · 2019-04-04T08:58:53Z

💔 Test failed - linux-rel-css

bors-servo · 2019-04-11T18:35:44Z

☔ The latest upstream changes (presumably #22521) made this pull request unmergeable. Please resolve the merge conflicts.

jdm · 2019-04-13T02:47:10Z

@bors-servo try=wpt

bors-servo · 2019-04-13T02:47:15Z

⌛ Trying commit 7726453 with merge 2c879fb...

Add referrer to navigation fetch request  Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22890 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)

bors-servo · 2019-04-13T03:09:34Z

💔 Test failed - linux-rel-css

miller-time · 2019-04-15T06:32:29Z

error: process didn't exit successfully: /home/travis/build/servo/servo/target/debug/deps/hang_monitor_tests-e2bf1aad70b8b79b (signal: 27)
The command "./mach test-unit" exited with 101.

Hmm I got this same error when running locally...

e: ran again with --verbose and it passed... then ran again without --verbose and it passed again... 🤔

jdm

The word "referrer" stopped making any sense to me while I was reading these changes, but this looks great to me! Thanks for clearing this up.

jdm · 2019-04-25T17:41:48Z

@bors-servo r=gterzian

bors-servo · 2019-04-25T17:41:48Z

📌 Commit 2440e0f has been approved by gterzian

bors-servo · 2019-04-25T18:00:51Z

⌛ Testing commit 2440e0f with merge 8346513...

Add referrer to navigation fetch request  Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22890 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)

bors-servo · 2019-04-25T18:35:56Z

💔 Test failed - linux-rel-wpt

jdm · 2019-04-25T18:55:16Z

@bors-servo retry

Intermittent CRASH with "mozilla::detail::MutexImpl::~MutexImpl: pthread_mutex_destroy failed: Device or resource busy" #21696

Add referrer to navigation fetch request  Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22890 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)

bors-servo · 2019-04-25T20:33:13Z

⌛ Testing commit 2440e0f with merge f89a163...

bors-servo · 2019-04-25T22:25:17Z

💔 Test failed - status-taskcluster

KiChjang · 2019-04-25T22:47:59Z

@bors-servo retry

bors-servo · 2019-04-26T00:21:25Z

⌛ Testing commit 2440e0f with merge b73956c...

Add referrer to navigation fetch request  Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22890 (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)

bors-servo · 2019-04-26T01:49:42Z

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: gterzian
Pushing b73956c to master...

gterzian · 2019-04-26T16:49:12Z

@miller-time thanks!

miller-time · 2019-04-26T17:14:31Z

@gterzian my pleasure 🙂 and thanks to you and @jdm for all the guidance along the way

highfive assigned nox Mar 25, 2019

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 25, 2019

miller-time force-pushed the nav-fetch-referrer branch from b0e8941 to bf794bc Compare March 26, 2019 01:08

miller-time mentioned this pull request Mar 26, 2019

Add "referrer" to fetch request used in navigation #22890

Closed

miller-time force-pushed the nav-fetch-referrer branch 2 times, most recently from b23618d to e98db92 Compare March 30, 2019 23:24

miller-time marked this pull request as ready for review March 31, 2019 00:10

highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 4, 2019

miller-time force-pushed the nav-fetch-referrer branch from e98db92 to a2e5c6a Compare April 8, 2019 05:16

highfive removed the S-tests-failed The changes caused existing tests to fail. label Apr 8, 2019

highfive added the S-needs-rebase There are merge conflict errors. label Apr 11, 2019

miller-time force-pushed the nav-fetch-referrer branch 2 times, most recently from 1bc61b5 to 7726453 Compare April 13, 2019 00:36

highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 13, 2019

miller-time force-pushed the nav-fetch-referrer branch from 7726453 to 15327b0 Compare April 15, 2019 01:54

highfive removed the S-tests-failed The changes caused existing tests to fail. label Apr 15, 2019

jdm approved these changes Apr 25, 2019

View reviewed changes

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Apr 25, 2019

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 25, 2019

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 25, 2019

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 25, 2019

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 26, 2019

bors-servo merged commit 2440e0f into servo:master Apr 26, 2019

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 26, 2019

bors-servo mentioned this pull request Apr 26, 2019

Use the global entry url in Location::SetHref #21926

Closed

Uh oh!

Add referrer to navigation fetch request #23090

Add referrer to navigation fetch request #23090

Uh oh!

Conversation

miller-time commented Mar 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented Mar 25, 2019

Uh oh!

highfive commented Mar 25, 2019

Uh oh!

highfive commented Mar 25, 2019

Uh oh!

gterzian commented Apr 4, 2019

Uh oh!

bors-servo commented Apr 4, 2019

Uh oh!

gterzian commented Apr 4, 2019

Uh oh!

bors-servo commented Apr 4, 2019

Uh oh!

bors-servo commented Apr 11, 2019

Uh oh!

jdm commented Apr 13, 2019

Uh oh!

bors-servo commented Apr 13, 2019

Uh oh!

bors-servo commented Apr 13, 2019

Uh oh!

miller-time commented Apr 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdm left a comment

Choose a reason for hiding this comment

Uh oh!

jdm commented Apr 25, 2019

Uh oh!

bors-servo commented Apr 25, 2019

Uh oh!

bors-servo commented Apr 25, 2019

Uh oh!

bors-servo commented Apr 25, 2019

Uh oh!

jdm commented Apr 25, 2019

Uh oh!

bors-servo commented Apr 25, 2019

Uh oh!

bors-servo commented Apr 25, 2019

Uh oh!

KiChjang commented Apr 25, 2019

Uh oh!

bors-servo commented Apr 26, 2019

Uh oh!

bors-servo commented Apr 26, 2019

Uh oh!

gterzian commented Apr 26, 2019

Uh oh!

miller-time commented Apr 26, 2019

Uh oh!

Uh oh!

miller-time commented Mar 25, 2019 •

edited

Loading

miller-time commented Apr 15, 2019 •

edited

Loading