Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referrer to navigation fetch request #23090

Merged
merged 2 commits into from Apr 26, 2019

Conversation

Projects
None yet
7 participants
@miller-time
Copy link
Contributor

commented Mar 25, 2019

Implement step 13 of following hyperlinks and step 14.3 of window open, as well as other referrer- and fetch-related updates.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22890 (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Mar 25, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

commented Mar 25, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/windowproxy.rs, components/script/dom/htmlanchorelement.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/script/dom/location.rs
  • @KiChjang: components/script/dom/windowproxy.rs, components/script/dom/htmlanchorelement.rs, components/script/script_thread.rs, components/script/dom/window.rs, components/net_traits/request.rs and 2 more
@highfive

This comment has been minimized.

Copy link

commented Mar 25, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@miller-time miller-time force-pushed the miller-time:nav-fetch-referrer branch from b0e8941 to bf794bc Mar 26, 2019

@miller-time miller-time force-pushed the miller-time:nav-fetch-referrer branch 2 times, most recently from b23618d to e98db92 Mar 27, 2019

@miller-time miller-time marked this pull request as ready for review Mar 31, 2019

@gterzian

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

⌛️ Trying commit e98db92 with merge 92a41b9...

bors-servo added a commit that referenced this pull request Apr 4, 2019

Auto merge of #23090 - miller-time:nav-fetch-referrer, r=<try>
Add referrer to navigation fetch request

<!-- Please describe your changes on the following line: -->
Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22890 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)
<!-- Reviewable:end -->
@gterzian

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

@miller-time Results from the tests will show up at https://build.servo.org/grid (look for the column matching the commits mentioned above by the bot)

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

💔 Test failed - linux-rel-css

@miller-time miller-time force-pushed the miller-time:nav-fetch-referrer branch from e98db92 to a2e5c6a Apr 8, 2019

@highfive highfive removed the S-tests-failed label Apr 8, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

☔️ The latest upstream changes (presumably #22521) made this pull request unmergeable. Please resolve the merge conflicts.

@miller-time miller-time force-pushed the miller-time:nav-fetch-referrer branch 2 times, most recently from 1bc61b5 to 7726453 Apr 12, 2019

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

@bors-servo try=wpt

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

⌛️ Trying commit 7726453 with merge 2c879fb...

bors-servo added a commit that referenced this pull request Apr 13, 2019

Auto merge of #23090 - miller-time:nav-fetch-referrer, r=<try>
Add referrer to navigation fetch request

<!-- Please describe your changes on the following line: -->
Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22890 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

💔 Test failed - linux-rel-css

@miller-time miller-time force-pushed the miller-time:nav-fetch-referrer branch from 7726453 to 15327b0 Apr 15, 2019

@miller-time

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

error: process didn't exit successfully: /home/travis/build/servo/servo/target/debug/deps/hang_monitor_tests-e2bf1aad70b8b79b (signal: 27)
The command "./mach test-unit" exited with 101.

Hmm I got this same error when running locally...

e: ran again with --verbose and it passed... then ran again without --verbose and it passed again... 🤔

@jdm

jdm approved these changes Apr 25, 2019

Copy link
Member

left a comment

The word "referrer" stopped making any sense to me while I was reading these changes, but this looks great to me! Thanks for clearing this up.

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

@bors-servo r=gterzian

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

📌 Commit 2440e0f has been approved by gterzian

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

⌛️ Testing commit 2440e0f with merge 8346513...

bors-servo added a commit that referenced this pull request Apr 25, 2019

Auto merge of #23090 - miller-time:nav-fetch-referrer, r=gterzian
Add referrer to navigation fetch request

<!-- Please describe your changes on the following line: -->
Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22890 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

💔 Test failed - linux-rel-wpt

@jdm

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

bors-servo added a commit that referenced this pull request Apr 25, 2019

Auto merge of #23090 - miller-time:nav-fetch-referrer, r=gterzian
Add referrer to navigation fetch request

<!-- Please describe your changes on the following line: -->
Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22890 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

⌛️ Testing commit 2440e0f with merge f89a163...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

💔 Test failed - status-taskcluster

@KiChjang

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

⌛️ Testing commit 2440e0f with merge b73956c...

bors-servo added a commit that referenced this pull request Apr 26, 2019

Auto merge of #23090 - miller-time:nav-fetch-referrer, r=gterzian
Add referrer to navigation fetch request

<!-- Please describe your changes on the following line: -->
Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22890 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster
Approved by: gterzian
Pushing b73956c to master...

@bors-servo bors-servo merged commit 2440e0f into servo:master Apr 26, 2019

4 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@gterzian

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

@miller-time thanks!

@miller-time

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@gterzian my pleasure 🙂 and thanks to you and @jdm for all the guidance along the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.