Switch the majority of fxhash uses to rustc_hash which is maintained #39168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slightly faster (according to the documentation). There is still some cases depending on stylo that have the old fxhash crate. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Narfinger
requested review from
Loirooriol,
gterzian,
mrobinson and
nicoburns
as code owners
sagudev
approved these changes
Sep 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fxhash seems to be unmaintained (see rustsec/advisory-db#2185) so we should move away from it.
Additionally, the new crate might be slightly faster.
There is still some cases depending on stylo that have the old fxhash
crate.
Signed-off-by: Narfinger Narfinger@users.noreply.github.com
Testing: Changes in Hash should really not show any bugs. And performance should be comparable.