script: Return `None` for `offsetParent` on root `<html>` and all `<body>` elements #39397

Loirooriol · 2025-09-19T14:47:18Z

We were returning null for all <html> elements, but now we will check for the root element instead.

We were also returning null for "the body element", now we will return null for all <body> elements even if they aren't "the body element". This part diverges from the spec, but matches what all browsers do. w3c/csswg-drafts#12834

Testing: Adding new test
Fixes: #10521

We were returning null for all `<html>` elements, but now we will check for the root element instead. We were also returning null for "the body element", now we will return null for all `<body>` elements even if they aren't "the body element". Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Oriol Brufau <obrufau@igalia.com>

github-actions · 2025-09-19T14:47:32Z

🔨 Triggering try run (#17861696254) for Linux (WPT)

servo-wpt-sync · 2025-09-19T14:50:18Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#54951) with upstreamable changes.

github-actions · 2025-09-19T15:14:47Z

Test results for linux-wpt from try job (#17861696254):

Flaky unexpected result (26)

OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
FAIL [expected PASS] /_mozilla/css/iframe/hide_and_show.html (#15265)
TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
- NOTRUN [expected PASS] subtest: Overall test
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-trademark-006.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-vendor-010.xht
FAIL [expected PASS] /css/WOFF2/tabledata-bad-origlength-loca-001.xht
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 125 but got 40
```
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-style: 'italic' should prefer 'oblique 5deg 10deg' over 'oblique 5deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
TIMEOUT [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/max-payload.tentative.https.window.html (#35210)
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
TIMEOUT [expected OK] /html/browsers/history/the-history-interface/traverse-during-unload.html (#28688)
- TIMEOUT [expected PASS] subtest: Traversing the history during unload
```
Test timed out
```
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected OK] /html/browsers/the-window-object/open-close/open-features-non-integer-top.html

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

TIMEOUT [expected OK] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-nonexistent.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with non-existent fragments should work.
```
Test timed out
```
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic test (normal form)
ERROR [expected OK] /html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url-base.html

OK /html/webappapis/user-prompts/print-during-unload.html (#35944)

FAIL [expected PASS] subtest: print() during unload

assert_array_equals: expected property 1 to be "destination" but got "error: window.print is not a function" (expected array ["start", "destination"] got ["start", "error: window.print is not a function"])

OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
ERROR /service-workers/idlharness.https.any.html (#36250)
- PASS [expected TIMEOUT] subtest: ServiceWorkerContainer interface: operation register((TrustedScriptURL or USVString), optional RegistrationOptions)
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation enable()
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation disable()
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation setHeaderValue(ByteString)
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation getState()
OK /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
- PASS [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.

OK /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html (#22849)

FAIL [expected PASS] subtest: buffer-stitching-2

assert_approx_equals: Stitched sine‑wave buffers at sample rate 43800 sample[34586] |-252805499584512 - 0.45811137557029724| = 252805499584512.47 &gt; 0.0038986 expected 0.45811137557029724 +/- 0.0038986 but got -252805499584512

ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)

Stable unexpected results that are known to be intermittent (23)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- PASS [expected FAIL] subtest: Revoke blob URL after calling fetch, fetch should succeed
FAIL [expected PASS] /_mozilla/css/stacked_layers.html (#15988)
FAIL [expected PASS] /_mozilla/gfx-rs-gecko/descriptor-ranges.html (#23258)
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
FAIL [expected PASS] /css/css-flexbox/flex-item-content-is-min-width-max-content.html (#39383)
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.tentative.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Same site
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
- PASS [expected FAIL] subtest: Check execution order on load handler
- PASS [expected FAIL] subtest: Check execution order from nested timeout
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
- FAIL [expected PASS] subtest: link click
```
assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored
```
assert_equals: expected "?pass" but got "?fail"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- FAIL [expected TIMEOUT] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
assert_equals: expected "DIV" but got "BODY"
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected FAIL] subtest: Element with tabindex should support autofocus
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Non-HTMLElement should not support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
- NOTRUN [expected TIMEOUT] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

OK /preload/preload-error.sub.html (#37177)

FAIL [expected PASS] subtest: success (fetch): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?label=fetch should be loaded expected a number greater than 0 but got 0

FAIL [expected PASS] subtest: 404 (fetch): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?pipe=status%28404%29&amp;label=fetch should be loaded expected a number greater than 0 but got 0

PASS [expected FAIL] subtest: CORS (fetch): main

OK /preload/preload-invalid-resources.html (#39091)
- FAIL [expected PASS] subtest: Preloading an invalid image (missing) should preload and not re-fetch
```
assert_equals: /nothing.png expected 1 but got 2
```
OK /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.

github-actions · 2025-09-19T15:14:58Z

✨ Try run (#17861696254) succeeded.

servo-wpt-sync · 2025-09-19T17:25:03Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#54951) title and body.

servo-wpt-sync · 2025-09-19T17:25:53Z

✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#54951) title and body.

Loirooriol added the T-linux-wpt Do a try run of the WPT label Sep 19, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Sep 19, 2025

servo-wpt-sync mentioned this pull request Sep 19, 2025

script: Return None for offsetParent on root <html> and all <body> elements web-platform-tests/wpt#54951

Merged

Loirooriol marked this pull request as ready for review September 19, 2025 15:16

Loirooriol requested a review from gterzian as a code owner September 19, 2025 15:16

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 19, 2025

mrobinson changed the title ~~script: Fix offsetParent on <html> and <body> elements~~ script: Return None for offsetParent on root <html> and all <body>` elements Sep 19, 2025

mrobinson changed the title ~~script: Return None for offsetParent on root <html> and all <body>` elements~~ script: Return None for offsetParent on root <html> and all <body> elements Sep 19, 2025

mrobinson approved these changes Sep 19, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Sep 19, 2025

mrobinson added this pull request to the merge queue Sep 19, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 19, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2025

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 19, 2025

Loirooriol added this pull request to the merge queue Sep 19, 2025

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 19, 2025

Loirooriol removed this pull request from the merge queue due to a manual request Sep 19, 2025

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 19, 2025

Loirooriol added this pull request to the merge queue Sep 19, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 19, 2025

Merged via the queue into servo:main with commit 994d767 Sep 19, 2025
73 checks passed

Loirooriol deleted the offsetParent-html-and-body branch September 19, 2025 20:35

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Uh oh!

script: Return `None` for `offsetParent` on root `<html>` and all `<body>` elements #39397

script: Return `None` for `offsetParent` on root `<html>` and all `<body>` elements #39397

Uh oh!

Loirooriol commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

servo-wpt-sync commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

servo-wpt-sync commented Sep 19, 2025

Uh oh!

servo-wpt-sync commented Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

script: Return None for offsetParent on root <html> and all <body> elements #39397

script: Return None for offsetParent on root <html> and all <body> elements #39397

Uh oh!

Conversation

Loirooriol commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

servo-wpt-sync commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

servo-wpt-sync commented Sep 19, 2025

Uh oh!

servo-wpt-sync commented Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

script: Return `None` for `offsetParent` on root `<html>` and all `<body>` elements #39397

script: Return `None` for `offsetParent` on root `<html>` and all `<body>` elements #39397