servoshell: Scale WebDriver mouse button coordinates by HiDPI scale factor #39472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor Mouse button events are sent in CSSPixel coordinates, but these need to so they need to converted into device coordinates when creating an input event for them. This isn't an issue for automated test because they always use a scale factor of 1. This is a problem when running interactively and not in headless mode. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
servo-highfive
added
the
S-awaiting-review
yezhizhen
approved these changes
Sep 24, 2025
servo-highfive
removed
the
S-awaiting-review
|
This should fix #38087 for all platforms except x11/windows. |
servo-highfive
added
the
S-awaiting-merge
|
@yezhizhen Thanks for the link to the bug. |
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mouse button events are sent in CSSPixel coordinates, but these need to
so they need to converted into device coordinates when creating an input
event for them. This isn't an issue for automated test because they
always use a scale factor of 1. This is a problem when running
interactively and not in headless mode.
Testing: This isn't really testable in an automated way, but is very obviously
causes tests to pass when run with WebDriver and without headless mode.
Fixes: Part of #38087.