layout: Cleanup clear_fragment_layout_cache() #40040
Merged
+28
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LayoutBox::clear_fragment_layout_cache()` was just redirecting to the `clear_fragment_layout_cache()` method of inner structures, until reaching `LayoutBoxBase` where the work is actually done. So this patch gets the `LayoutBoxBase` first, and then calls the method on it. To do so, `LayoutBox::with_base_fold()` is added as a non-mutable version of the existing `LayoutBox::with_base_mut_fold()`. But since we the return value doesn't matter, `LayoutBox::with_each_base()` is also added as a tiny helper around `LayoutBox::with_base_fold()`. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Loirooriol
added
the
A-layout/2020
servo-highfive
added
the
S-awaiting-review
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutBox::clear_fragment_layout_cache()was just redirecting to theclear_fragment_layout_cache()method of inner structures, until reachingLayoutBoxBasewhere the work is actually done.So this patch gets the
LayoutBoxBasefirst, and then calls the method on it. To do so,LayoutBox::with_base_fold()is added as a non-mutable version of the existingLayoutBox::with_base_mut_fold(). But since we the return value doesn't matter,LayoutBox::with_each_base()is also added as a tiny helper aroundLayoutBox::with_base_fold().Testing: Not needed, no behavior change