compositing: Initialize the WebRender image handlers with the IOCompositor #40134
+305
−264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servo-highfive
added
the
S-awaiting-review
mrobinson
force-pushed
the
initialize-image-handlers-in-compositor
branch
from
0cd66f8 to
461d880
Compare
mukilan
force-pushed
the
initialize-image-handlers-in-compositor
branch
from
461d880 to
aace048
Compare
mukilan
approved these changes
Oct 24, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
mukilan
force-pushed
the
initialize-image-handlers-in-compositor
branch
from
aace048 to
72366e1
Compare
servo-highfive
added
S-awaiting-review
…sitor In order to move all WebRender initialization closer to the renderer, so that it can support multiple WebRender instances, move all external image handler initialiazation into `compositing`. This also modifies the order of initalization. Now the `IOCompositor` (renderer) starts before the `Constellation`. This will be useful when Servo construction can fail, so that we fail before starting a `Constellation` thread. Finally, replace all occurences of "Webrender" with "WebRender". Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mukilan
force-pushed
the
initialize-image-handlers-in-compositor
branch
from
72366e1 to
829af8c
Compare
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to move all WebRender initialization closer to the renderer,
so that it can support multiple WebRender instances, move all external
image handler initialiazation into
compositing.This also modifies the order of initalization. Now the
IOCompositor(renderer) starts before the
Constellation. This will be usefulwhen Servo construction can fail, so that we fail before starting a
Constellationthread.Finally, replace all occurences of "Webrender" with "WebRender".
Testing: This should not change behavior so is covered by existing tests.