tools: Use ISO8601 timestamps and filter ports correctly in the Devtools parser #40428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change in tshark makes it emit timestamps in ISO 8601 format (https://gitlab.com/wireshark/wireshark/-/merge_requests/17273), which breaks the existing parser. Simplify the code to simply print the new timestamp as is. The captured messages were not being filtered correctly by the devtools port, which could result in messy logs. The `-f "tcp port ..."` option filters the port, while `-d "tcp.port==...,http"` just specifies how the messages from that port should be treated. Simplify the tshark command function and some variable names. Signed-off-by: eri <eri@igalia.com>
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Nov 5, 2025
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: eri <eri@igalia.com>
servo-highfive
added
the
S-awaiting-review
mrobinson
changed the title
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in tshark makes it emit timestamps in ISO 8601 format (https://gitlab.com/wireshark/wireshark/-/merge_requests/17273), which breaks the existing parser. Simplify the code to simply print the new timestamp as is.
The captured messages were not being filtered correctly by the devtools port, which could result in messy logs. The
-f "tcp port ..."option filters the port, while-d "tcp.port==...,http"just specifies how the messages from that port should be treated.Simplify the tshark command function and some variable names.
Testing: Using
mach test-scripts.