Skip to content

servoshell: Move webdriver_receiver to shared base #40538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2025
Merged

servoshell: Move webdriver_receiver to shared base #40538

merged 1 commit into from
Nov 10, 2025

Conversation

@atbrakhi
Copy link
Member

@atbrakhi atbrakhi commented Nov 10, 2025

This PR eliminates duplicate code while maintaining the same functionality across all platforms.. We move webdriver_receiver to shared base where webdriver_sender lives

Testing: No functional changes. Existing tests should test this.
Fixes: Part of #40530

@atbrakhi atbrakhi requested a review from jschwe as a code owner November 10, 2025 12:53
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 10, 2025
@atbrakhi atbrakhi added T-android Do a try run on Android T-ohos Do a try run on OpenHarmony and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 10, 2025
@github-actions github-actions bot removed T-android Do a try run on Android T-ohos Do a try run on OpenHarmony labels Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

🔨 Triggering try run (#19232308032) for Android, OpenHarmony

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

⚠️ Try run (#19232308032) failed.

@atbrakhi
servoshell: Move webdriver_receiver to shared base
7b793dc 
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
@atbrakhi atbrakhi force-pushed the move_webdriver_receiver branch from 3f87f5a to 7b793dc Compare November 10, 2025 15:47
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 10, 2025
@atbrakhi atbrakhi added T-android Do a try run on Android T-ohos Do a try run on OpenHarmony labels Nov 10, 2025
@github-actions github-actions bot removed T-android Do a try run on Android T-ohos Do a try run on OpenHarmony labels Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

🔨 Triggering try run (#19237387547) for Android, OpenHarmony

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

🐰 Bencher Report

Branch40538/PR
TestbedHUAWEI Mate 60 Pro

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkDataMeasure (units) x 1e3Latencymilliseconds (ms)MemoryBytesscoreMeasure (units)
release/E2E/file:///parse_from_string.html/📈 view plot
⚠️ NO THRESHOLD		1.86 units x 1e3
release/E2E/https://www.google.com/JS/gc-heap/admin📈 view plot
⚠️ NO THRESHOLD		26,752.00
release/E2E/https://www.google.com/JS/gc-heap/decommitted📈 view plot
⚠️ NO THRESHOLD		409,600.00
release/E2E/https://www.google.com/JS/gc-heap/unused📈 view plot
⚠️ NO THRESHOLD		136,136.00
release/E2E/https://www.google.com/JS/gc-heap/used📈 view plot
⚠️ NO THRESHOLD		476,088.00
release/E2E/https://www.google.com/JS/malloc-heap📈 view plot
⚠️ NO THRESHOLD		5,053,575.00
release/E2E/https://www.google.com/JS/non-heap📈 view plot
⚠️ NO THRESHOLD		262,144.00
release/E2E/https://www.google.com/LayoutThread/box-tree📈 view plot
⚠️ NO THRESHOLD		108,744.00
release/E2E/https://www.google.com/LayoutThread/display-list📈 view plot
⚠️ NO THRESHOLD		0.00
release/E2E/https://www.google.com/LayoutThread/font-context📈 view plot
⚠️ NO THRESHOLD		8,616.00
release/E2E/https://www.google.com/LayoutThread/fragment-tree📈 view plot
⚠️ NO THRESHOLD		112.00
release/E2E/https://www.google.com/LayoutThread/stacking-context-tree📈 view plot
⚠️ NO THRESHOLD		14,080.00
release/E2E/https://www.google.com/LayoutThread/stylist📈 view plot
⚠️ NO THRESHOLD		5,504.00
release/E2E/https://www.google.com/Load📈 view plot
⚠️ NO THRESHOLD		668.84 ms
release/E2E/https://www.google.com/Resident📈 view plot
⚠️ NO THRESHOLD		184,791,859.00
release/E2E/https://www.google.com/image-cache📈 view plot
⚠️ NO THRESHOLD		2,328.00
release/E2E/https://www.google.com/resident-smaps📈 view plot
⚠️ NO THRESHOLD		186,653,081.00
release/E2E/https://www.servo.org/Load📈 view plot
⚠️ NO THRESHOLD		899.50 ms
release/E2E/https://www.servo.org/Resident📈 view plot
⚠️ NO THRESHOLD		253,671,833.00
release/E2E/https://www.servo.org/resident-smaps📈 view plot
⚠️ NO THRESHOLD		255,040,716.00
release/Speedometer/Charts-observable-plot📈 view plot
⚠️ NO THRESHOLD		802.25 ms
release/Speedometer/Charts-observable-plot/Dotted📈 view plot
⚠️ NO THRESHOLD		98.35 ms
release/Speedometer/Charts-observable-plot/Dotted/Async📈 view plot
⚠️ NO THRESHOLD		10.64 ms
release/Speedometer/Charts-observable-plot/Dotted/Sync📈 view plot
⚠️ NO THRESHOLD		87.71 ms
release/Speedometer/Charts-observable-plot/Stacked by 20📈 view plot
⚠️ NO THRESHOLD		391.24 ms
release/Speedometer/Charts-observable-plot/Stacked by 20/Async📈 view plot
⚠️ NO THRESHOLD		18.49 ms
release/Speedometer/Charts-observable-plot/Stacked by 20/Sync📈 view plot
⚠️ NO THRESHOLD		372.75 ms
release/Speedometer/Charts-observable-plot/Stacked by 6📈 view plot
⚠️ NO THRESHOLD		312.65 ms
release/Speedometer/Charts-observable-plot/Stacked by 6/Async📈 view plot
⚠️ NO THRESHOLD		10.99 ms
release/Speedometer/Charts-observable-plot/Stacked by 6/Sync📈 view plot
⚠️ NO THRESHOLD		301.67 ms
release/Speedometer/Geomean📈 view plot
⚠️ NO THRESHOLD		696.71 ms
release/Speedometer/Iteration-0-Total📈 view plot
⚠️ NO THRESHOLD		846.42 ms
release/Speedometer/Iteration-1-Total📈 view plot
⚠️ NO THRESHOLD		829.63 ms
release/Speedometer/Iteration-2-Total📈 view plot
⚠️ NO THRESHOLD		831.36 ms
release/Speedometer/Iteration-3-Total📈 view plot
⚠️ NO THRESHOLD		828.90 ms
release/Speedometer/Iteration-4-Total📈 view plot
⚠️ NO THRESHOLD		926.44 ms
release/Speedometer/Iteration-5-Total📈 view plot
⚠️ NO THRESHOLD		1,100.52 ms
release/Speedometer/Iteration-6-Total📈 view plot
⚠️ NO THRESHOLD		1,099.28 ms
release/Speedometer/Iteration-7-Total📈 view plot
⚠️ NO THRESHOLD		987.43 ms
release/Speedometer/Iteration-8-Total📈 view plot
⚠️ NO THRESHOLD		1,089.04 ms
release/Speedometer/Iteration-9-Total📈 view plot
⚠️ NO THRESHOLD		1,112.10 ms
release/Speedometer/Score📈 view plot
⚠️ NO THRESHOLD		1.45 units
release/Speedometer/TodoMVC-Angular📈 view plot
⚠️ NO THRESHOLD		996.65 ms
release/Speedometer/TodoMVC-Angular/Adding100Items📈 view plot
⚠️ NO THRESHOLD		475.89 ms
release/Speedometer/TodoMVC-Angular/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		32.36 ms
release/Speedometer/TodoMVC-Angular/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		443.53 ms
release/Speedometer/TodoMVC-Angular/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		322.73 ms
release/Speedometer/TodoMVC-Angular/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		39.22 ms
release/Speedometer/TodoMVC-Angular/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		283.50 ms
release/Speedometer/TodoMVC-Angular/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		198.04 ms
release/Speedometer/TodoMVC-Angular/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		7.24 ms
release/Speedometer/TodoMVC-Angular/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		190.80 ms
release/Speedometer/TodoMVC-JavaScript-ES5📈 view plot
⚠️ NO THRESHOLD		1,515.71 ms
release/Speedometer/TodoMVC-JavaScript-ES5/Adding100Items📈 view plot
⚠️ NO THRESHOLD		1,238.65 ms
release/Speedometer/TodoMVC-JavaScript-ES5/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		54.92 ms
release/Speedometer/TodoMVC-JavaScript-ES5/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		1,183.74 ms
release/Speedometer/TodoMVC-JavaScript-ES5/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		172.61 ms
release/Speedometer/TodoMVC-JavaScript-ES5/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		31.87 ms
release/Speedometer/TodoMVC-JavaScript-ES5/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		140.75 ms
release/Speedometer/TodoMVC-JavaScript-ES5/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		104.45 ms
release/Speedometer/TodoMVC-JavaScript-ES5/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		7.40 ms
release/Speedometer/TodoMVC-JavaScript-ES5/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		97.05 ms
release/Speedometer/TodoMVC-JavaScript-ES6-Webpack📈 view plot
⚠️ NO THRESHOLD		2,151.80 ms
release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/Adding100Items📈 view plot
⚠️ NO THRESHOLD		1,752.71 ms
release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		36.59 ms
release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		1,716.12 ms
release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		250.72 ms
release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		36.93 ms
release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		213.79 ms
release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		148.37 ms
release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		7.57 ms
release/Speedometer/TodoMVC-JavaScript-ES6-Webpack/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		140.79 ms
release/Speedometer/TodoMVC-Preact📈 view plot
⚠️ NO THRESHOLD		165.21 ms
release/Speedometer/TodoMVC-Preact/Adding100Items📈 view plot
⚠️ NO THRESHOLD		83.87 ms
release/Speedometer/TodoMVC-Preact/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		75.45 ms
release/Speedometer/TodoMVC-Preact/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		8.42 ms
release/Speedometer/TodoMVC-Preact/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		64.69 ms
release/Speedometer/TodoMVC-Preact/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		51.58 ms
release/Speedometer/TodoMVC-Preact/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		13.11 ms
release/Speedometer/TodoMVC-Preact/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		16.64 ms
release/Speedometer/TodoMVC-Preact/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		10.69 ms
release/Speedometer/TodoMVC-Preact/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		5.95 ms
release/Speedometer/TodoMVC-React📈 view plot
⚠️ NO THRESHOLD		852.87 ms
release/Speedometer/TodoMVC-React-Redux📈 view plot
⚠️ NO THRESHOLD		1,095.69 ms
release/Speedometer/TodoMVC-React-Redux/Adding100Items📈 view plot
⚠️ NO THRESHOLD		349.52 ms
release/Speedometer/TodoMVC-React-Redux/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		37.57 ms
release/Speedometer/TodoMVC-React-Redux/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		311.96 ms
release/Speedometer/TodoMVC-React-Redux/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		486.26 ms
release/Speedometer/TodoMVC-React-Redux/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		37.65 ms
release/Speedometer/TodoMVC-React-Redux/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		448.60 ms
release/Speedometer/TodoMVC-React-Redux/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		259.91 ms
release/Speedometer/TodoMVC-React-Redux/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		8.25 ms
release/Speedometer/TodoMVC-React-Redux/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		251.66 ms
release/Speedometer/TodoMVC-React/Adding100Items📈 view plot
⚠️ NO THRESHOLD		297.95 ms
release/Speedometer/TodoMVC-React/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		39.87 ms
release/Speedometer/TodoMVC-React/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		258.08 ms
release/Speedometer/TodoMVC-React/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		352.24 ms
release/Speedometer/TodoMVC-React/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		37.12 ms
release/Speedometer/TodoMVC-React/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		315.12 ms
release/Speedometer/TodoMVC-React/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		202.68 ms
release/Speedometer/TodoMVC-React/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		8.17 ms
release/Speedometer/TodoMVC-React/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		194.51 ms
release/Speedometer/TodoMVC-Svelte📈 view plot
⚠️ NO THRESHOLD		140.71 ms
release/Speedometer/TodoMVC-Svelte/Adding100Items📈 view plot
⚠️ NO THRESHOLD		78.40 ms
release/Speedometer/TodoMVC-Svelte/Adding100Items/Async📈 view plot
⚠️ NO THRESHOLD		59.70 ms
release/Speedometer/TodoMVC-Svelte/Adding100Items/Sync📈 view plot
⚠️ NO THRESHOLD		18.69 ms
release/Speedometer/TodoMVC-Svelte/CompletingAllItems📈 view plot
⚠️ NO THRESHOLD		46.56 ms
release/Speedometer/TodoMVC-Svelte/CompletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		37.24 ms
release/Speedometer/TodoMVC-Svelte/CompletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		9.32 ms
release/Speedometer/TodoMVC-Svelte/DeletingAllItems📈 view plot
⚠️ NO THRESHOLD		15.76 ms
release/Speedometer/TodoMVC-Svelte/DeletingAllItems/Async📈 view plot
⚠️ NO THRESHOLD		11.18 ms
release/Speedometer/TodoMVC-Svelte/DeletingAllItems/Sync📈 view plot
⚠️ NO THRESHOLD		4.57 ms
🐰 View full continuous benchmarking report in Bencher

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

✨ Try run (#19237387547) succeeded.

@atbrakhi atbrakhi added this pull request to the merge queue Nov 10, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 10, 2025
Merged via the queue into servo:main with commit b822e83 Nov 10, 2025
62 checks passed
@atbrakhi atbrakhi deleted the move_webdriver_receiver branch November 10, 2025 18:42
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 10, 2025
@atbrakhi atbrakhi mentioned this pull request Nov 11, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrobinson mrobinson mrobinson approved these changes

@jschwe jschwe Awaiting requested review from jschwe jschwe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atbrakhi @mrobinson @servo-highfive