script: Return only a JoinHandle from ScriptThread constructor
#40571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `JoinHandle` was added as a newer return value from this constructor. Both return values accomplish more or less the same thing. The difference is that the `Sender` return value is triggered right before the thread ends while the `JoinHandle` is triggered after thread completion. One was used in multiprocess mode and one in single process mode. In any case, the `JoinHandle` works fine for both cases. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
servo-highfive
added
the
S-awaiting-review
mukilan
approved these changes
Nov 12, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JoinHandlewas added as a newer return value from thisconstructor. Both return values accomplish more or less the same thing.
The difference is that the
Senderreturn value is triggered rightbefore the thread ends while the
JoinHandleis triggered after threadcompletion. One was used in multiprocess mode and one in single process
mode. In any case, the
JoinHandleworks fine for both cases.Testing: Multiprocess isn't tested currently, but I confirmed that the
ScripThread shut down properly in multiprocess mode with this change.