Skip to content

Let static prefs default to style_config's prefs#306

Merged
Loirooriol merged 1 commit intoservo:mainfrom
Loirooriol:prefs-from-servo
Feb 8, 2026
Merged

Let static prefs default to style_config's prefs#306
Loirooriol merged 1 commit intoservo:mainfrom
Loirooriol:prefs-from-servo

Conversation

@Loirooriol
Copy link
Copy Markdown
Collaborator

@Loirooriol Loirooriol commented Feb 6, 2026

This will allow Servo to enable them e.g. when turning on experimental features (--enable-experimental-web-platform-features), or when running specific tests.

Servo PR: servo/servo#42410

This will allow Servo to enable them when turning on experimental
features (--enable-experimental-web-platform-features).

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
@nicoburns
Copy link
Copy Markdown
Collaborator

Hmm... isn't the point of static prefs that they compile out entirely. If we're doing a runtime pref then that should probably be an explicit calls into style_config from the style crate?

@Loirooriol
Copy link
Copy Markdown
Collaborator Author

Well, Firefox uses static_prefs::pref!() and you can change prefs during runtime.

@Loirooriol
Copy link
Copy Markdown
Collaborator Author

The "static" part is indeed confusing if they aren't really static... But apparently in Firefox static_prefs is just what exposes Gecko prefs to rust.

@nicoburns
Copy link
Copy Markdown
Collaborator

Oh huh. I see that gecko doesn't have an equivalent to style_config at all (it just uses it's equivalent to static_prefs). In that case I have no objection We could even consider merging our two config crates.

@Loirooriol
Copy link
Copy Markdown
Collaborator Author

Loirooriol commented Feb 6, 2026

Yeah, I guess the crates should be merged, and most of the prefs that we are setting in stylo_static_prefs/src/lib.rs should be set from Servo (or Blitz or whatever). But can be left for follow-ups.

@Loirooriol Loirooriol marked this pull request as ready for review February 6, 2026 20:36
@Loirooriol Loirooriol added this pull request to the merge queue Feb 8, 2026
Merged via the queue into servo:main with commit d99b4a5 Feb 8, 2026
5 checks passed
@Loirooriol Loirooriol deleted the prefs-from-servo branch February 8, 2026 12:58
github-merge-queue Bot pushed a commit to servo/servo that referenced this pull request Feb 8, 2026
The implementation of `attr()` in Stylo is not complete, but this way we
can start testing for it.

Bumps Stylo to servo/stylo#306

Testing: Various tests pass, also a few failures. No impact on users,
even with experimental features enabled.

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
github-merge-queue Bot pushed a commit to servo/servo that referenced this pull request Feb 8, 2026
The implementation of `attr()` in Stylo is not complete, but this way we
can start testing for it.

Bumps Stylo to servo/stylo#306

Testing: Various tests pass, also a few failures. No impact on users,
even with experimental features enabled.

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants